Re: [FFmpeg-devel] [PATCH] avcodec/h264dec: Remove dead function

2023-03-15 Thread Kieran Kunhya
On Wed, 15 Mar 2023 at 18:07, Kieran Kunhya wrote: > (Given the lack of the flag, ut would have been either illegal for the >> caller to set draw_horiz_band or for the decoder to call it.) >> > > This is not a documented restriction: > https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/avcod

Re: [FFmpeg-devel] [PATCH] avcodec/h264dec: Remove dead function

2023-03-15 Thread Kieran Kunhya
> > (Given the lack of the flag, ut would have been either illegal for the > caller to set draw_horiz_band or for the decoder to call it.) > This is not a documented restriction: https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/avcodec.h#L637 Kieran

Re: [FFmpeg-devel] [PATCH] avcodec/h264dec: Remove dead function

2023-03-15 Thread Kieran Kunhya
> > As far as I know, this codec never had the AV_CODEC_CAP_DRAW_HORIZ_BAND > flag set (the commented out flag was removed in > e0c01a62adf59d1866ec53dcd76e4d4c815c5d58). Are you sure it ever worked? > Do you know someone who uses draw_horiz_band? > (Given the lack of the flag, ut would have been e

Re: [FFmpeg-devel] [PATCH] avcodec/h264dec: Remove dead function

2023-03-15 Thread Andreas Rheinhardt
Kieran Kunhya: > On Wed, 15 Mar 2023 at 17:17, Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Andreas Rheinhardt: >>> The H.264 decoder does not support draw_horiz_band (it does not have >>> the AV_CODEC_CAP_DRAW_HORIZ_BAND), making ff_h264_draw_horiz_band() >>> practically dea

Re: [FFmpeg-devel] [PATCH] avcodec/h264dec: Remove dead function

2023-03-15 Thread Kieran Kunhya
On Wed, 15 Mar 2023 at 17:17, Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Andreas Rheinhardt: > > The H.264 decoder does not support draw_horiz_band (it does not have > > the AV_CODEC_CAP_DRAW_HORIZ_BAND), making ff_h264_draw_horiz_band() > > practically dead. > > > > Signed-off-

Re: [FFmpeg-devel] [PATCH] avcodec/h264dec: Remove dead function

2023-03-15 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The H.264 decoder does not support draw_horiz_band (it does not have > the AV_CODEC_CAP_DRAW_HORIZ_BAND), making ff_h264_draw_horiz_band() > practically dead. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/dxva2_h264.c | 7 +-- > libavcodec/h264_slice.c | 2