Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Christophe Gisquet
Hi, 2015-03-12 16:17 GMT+01:00 Michael Niedermayer : > i belive any motion vector that points left outside the picture will > trigger this one OK I thought it was a magnitude issue, it's actually mvx being negative. That's indeed mighty weird and didn't know about this. > the compiler should opt

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Christophe Gisquet
Hi, 2015-03-12 16:29 GMT+01:00 Michael Niedermayer : > from "(mx >> 2) << pixel_shift)" a compiler could imply that > (mx >> 2) is >= 0 as the alterantive is undefined Well, (mvx >> 2) is implementation-defined, according to 6.5.7. But gcc produces the same instruction, so... -- Christophe

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 04:17:30PM +0100, Michael Niedermayer wrote: > On Thu, Mar 12, 2015 at 03:39:51PM +0100, Christophe Gisquet wrote: > > Hi, > > > > 2015-03-12 14:37 GMT+01:00 Michael Niedermayer : > > >> > const int mx = h->mv_cache[list][scan8[n]][0] + src_x_offset > > >> > * 8;

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 03:39:51PM +0100, Christophe Gisquet wrote: > Hi, > > 2015-03-12 14:37 GMT+01:00 Michael Niedermayer : > >> > const int mx = h->mv_cache[list][scan8[n]][0] + src_x_offset * > >> > 8; > >> > int my= h->mv_cache[list][scan8[n]][1] + src_y_offset *

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Christophe Gisquet
Hi, 2015-03-12 14:37 GMT+01:00 Michael Niedermayer : >> > const int mx = h->mv_cache[list][scan8[n]][0] + src_x_offset * 8; >> > int my= h->mv_cache[list][scan8[n]][1] + src_y_offset * 8; >> > const int luma_xy = (mx & 3) + ((my & 3) << 2); >> > -ptrdiff_t offse

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 09:57:44AM -0400, Ronald S. Bultje wrote: > Hi, > > On Thu, Mar 12, 2015 at 9:37 AM, Michael Niedermayer > wrote: > > > On Thu, Mar 12, 2015 at 07:14:54AM -0400, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Wed, Mar 11, 2015 at 9:00 PM, Michael Niedermayer > > > wrot

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Ronald S. Bultje
Hi, On Thu, Mar 12, 2015 at 9:37 AM, Michael Niedermayer wrote: > On Thu, Mar 12, 2015 at 07:14:54AM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Mar 11, 2015 at 9:00 PM, Michael Niedermayer > > wrote: > > > > > Found-by: Clang -fsanitize=shift > > > Reported-by: Thierry Foucu > > >

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 07:14:54AM -0400, Ronald S. Bultje wrote: > Hi, > > On Wed, Mar 11, 2015 at 9:00 PM, Michael Niedermayer > wrote: > > > Found-by: Clang -fsanitize=shift > > Reported-by: Thierry Foucu > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/h264_mb.c | 14 ++

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix undefined shifts

2015-03-12 Thread Ronald S. Bultje
Hi, On Wed, Mar 11, 2015 at 9:00 PM, Michael Niedermayer wrote: > Found-by: Clang -fsanitize=shift > Reported-by: Thierry Foucu > Signed-off-by: Michael Niedermayer > --- > libavcodec/h264_mb.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/libavcode