Re: [FFmpeg-devel] [PATCH] avcodec/apedec: use int64_t for FFABS

2015-10-12 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 11:52 AM, Ganesh Ajjanagadde wrote: > On Mon, Oct 12, 2015 at 11:43 AM, Michael Niedermayer > wrote: >> On Mon, Oct 12, 2015 at 11:22:17AM -0400, Ganesh Ajjanagadde wrote: >>> On Mon, Oct 12, 2015 at 11:09 AM, Michael Niedermayer >>> wrote: >>> > On Fri, Oct 09, 2015 at 0

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: use int64_t for FFABS

2015-10-12 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 11:43 AM, Michael Niedermayer wrote: > On Mon, Oct 12, 2015 at 11:22:17AM -0400, Ganesh Ajjanagadde wrote: >> On Mon, Oct 12, 2015 at 11:09 AM, Michael Niedermayer >> wrote: >> > On Fri, Oct 09, 2015 at 01:48:10PM -0400, Ganesh Ajjanagadde wrote: >> >> res, absres are curr

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: use int64_t for FFABS

2015-10-12 Thread Michael Niedermayer
On Mon, Oct 12, 2015 at 11:22:17AM -0400, Ganesh Ajjanagadde wrote: > On Mon, Oct 12, 2015 at 11:09 AM, Michael Niedermayer > wrote: > > On Fri, Oct 09, 2015 at 01:48:10PM -0400, Ganesh Ajjanagadde wrote: > >> res, absres are currently int's, which on most platforms is 32 bits. > >> Unfortunately,

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: use int64_t for FFABS

2015-10-12 Thread Ronald S. Bultje
Hi, On Fri, Oct 9, 2015 at 1:48 PM, Ganesh Ajjanagadde wrote: > res, absres are currently int's, which on most platforms is 32 bits. > Unfortunately, data is untrusted, and on line 1267 res is manipulated > with data. Thus, res can take on INT32_MIN/INT_MIN with crafted data, > making FFABS on l

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: use int64_t for FFABS

2015-10-12 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 11:23 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Oct 9, 2015 at 1:48 PM, Ganesh Ajjanagadde > wrote: >> >> res, absres are currently int's, which on most platforms is 32 bits. >> Unfortunately, data is untrusted, and on line 1267 res is manipulated >> with data. Thus, r

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: use int64_t for FFABS

2015-10-12 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 11:09 AM, Michael Niedermayer wrote: > On Fri, Oct 09, 2015 at 01:48:10PM -0400, Ganesh Ajjanagadde wrote: >> res, absres are currently int's, which on most platforms is 32 bits. >> Unfortunately, data is untrusted, and on line 1267 res is manipulated >> with data. Thus, re

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: use int64_t for FFABS

2015-10-12 Thread Michael Niedermayer
On Fri, Oct 09, 2015 at 01:48:10PM -0400, Ganesh Ajjanagadde wrote: > res, absres are currently int's, which on most platforms is 32 bits. > Unfortunately, data is untrusted, and on line 1267 res is manipulated > with data. Thus, res can take on INT32_MIN/INT_MIN with crafted data, > making FFABS o

Re: [FFmpeg-devel] [PATCH] avcodec/apedec: use int64_t for FFABS

2015-10-12 Thread Ganesh Ajjanagadde
On Fri, Oct 9, 2015 at 1:48 PM, Ganesh Ajjanagadde wrote: > res, absres are currently int's, which on most platforms is 32 bits. > Unfortunately, data is untrusted, and on line 1267 res is manipulated > with data. Thus, res can take on INT32_MIN/INT_MIN with crafted data, > making FFABS on line 12