Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-28 Thread Zhao Zhili
> 在 2023年12月29日，上午7:42，Marton Balint 写道： > >  > >> On Mon, 25 Dec 2023, Anton Khirnov wrote: >> >> Quoting Zhao Zhili (2023-12-25 10:27:59) >>> > On Dec 25, 2023, at 16:38, Anton Khirnov wrote: >>> > > Quoting Kacper Michajlow (2023-12-24 11:41:52) >>> >> On Fri, 22 Dec 2023 at 14:57, Anton

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-28 Thread Marton Balint
On Mon, 25 Dec 2023, Anton Khirnov wrote: Quoting Zhao Zhili (2023-12-25 10:27:59) > On Dec 25, 2023, at 16:38, Anton Khirnov wrote: > > Quoting Kacper Michajlow (2023-12-24 11:41:52) >> On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: >>> >>> Quoting Andreas Rheinhardt (2023-12-22 1

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-27 Thread Kacper Michajlow
On Mon, 25 Dec 2023 at 11:48, Zhao Zhili wrote: > > > > > On Dec 25, 2023, at 18:21, Anton Khirnov wrote: > > > > Quoting Zhao Zhili (2023-12-25 10:27:59) > >> > >> > >>> On Dec 25, 2023, at 16:38, Anton Khirnov wrote: > >>> > >>> Quoting Kacper Michajlow (2023-12-24 11:41:52) > On Fri, 22

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-25 Thread Zhao Zhili
> On Dec 25, 2023, at 18:21, Anton Khirnov wrote: > > Quoting Zhao Zhili (2023-12-25 10:27:59) >> >> >>> On Dec 25, 2023, at 16:38, Anton Khirnov wrote: >>> >>> Quoting Kacper Michajlow (2023-12-24 11:41:52) On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: > > Quoting Andre

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-25 Thread Anton Khirnov
Quoting Zhao Zhili (2023-12-25 10:27:59) > > > > On Dec 25, 2023, at 16:38, Anton Khirnov wrote: > > > > Quoting Kacper Michajlow (2023-12-24 11:41:52) > >> On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: > >>> > >>> Quoting Andreas Rheinhardt (2023-12-22 14:48:45) > Avoids relocation

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-25 Thread Zhao Zhili
> On Dec 25, 2023, at 16:38, Anton Khirnov wrote: > > Quoting Kacper Michajlow (2023-12-24 11:41:52) >> On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: >>> >>> Quoting Andreas Rheinhardt (2023-12-22 14:48:45) Avoids relocations. Signed-off-by: Andreas Rheinhardt --- >

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-25 Thread Anton Khirnov
Quoting Kacper Michajlow (2023-12-24 11:41:52) > On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: > > > > Quoting Andreas Rheinhardt (2023-12-22 14:48:45) > > > Avoids relocations. > > > > > > Signed-off-by: Andreas Rheinhardt > > > --- > > > > Maybe mention that it's not needed after > > acf63

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-24 Thread Kacper Michajlow
On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: > > Quoting Andreas Rheinhardt (2023-12-22 14:48:45) > > Avoids relocations. > > > > Signed-off-by: Andreas Rheinhardt > > --- > > Maybe mention that it's not needed after > acf63d5350adeae551d412db699f8ca03f7e76b9. This is not the only user of

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-22 Thread Rémi Denis-Courmont
Le perjantaina 22. joulukuuta 2023, 18.13.51 EET Andreas Rheinhardt a écrit : > Rémi Denis-Courmont: > > Le perjantaina 22. joulukuuta 2023, 15.48.45 EET Andreas Rheinhardt a écrit : > >> Avoids relocations. > > > > This is a little bit misleading. It reduces the number of relocations > > indeed,

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-22 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > Le perjantaina 22. joulukuuta 2023, 15.48.45 EET Andreas Rheinhardt a écrit : >> Avoids relocations. > > This is a little bit misleading. It reduces the number of relocations indeed, > but the data structures still end up in nonshareable .data.relro rather than > .rodata d

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-22 Thread Rémi Denis-Courmont
Le perjantaina 22. joulukuuta 2023, 15.48.45 EET Andreas Rheinhardt a écrit : > Avoids relocations. This is a little bit misleading. It reduces the number of relocations indeed, but the data structures still end up in nonshareable .data.relro rather than .rodata due to other remaining pointers.

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-22 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2023-12-22 14:48:45) > Avoids relocations. > > Signed-off-by: Andreas Rheinhardt > --- Maybe mention that it's not needed after acf63d5350adeae551d412db699f8ca03f7e76b9. LGTM otherwise. -- Anton Khirnov ___ ffmpeg-devel m