Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-11-14 Thread pkv.stream
Le 14/11/2017 à 11:14 PM, Carl Eugen Hoyos a écrit : 2017-11-14 21:01 GMT+01:00 pkv.stream : Le 14/11/2017 à 1:20 AM, Carl Eugen Hoyos a écrit : 2017-11-09 9:01 GMT+01:00 pkv.stream : 1) there are changes to make to the list of channel layouts not requiring PCE ==> AV_CH_LAYOUT_5POINT0 to AV

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-11-14 Thread Carl Eugen Hoyos
2017-11-14 21:01 GMT+01:00 pkv.stream : > Le 14/11/2017 à 1:20 AM, Carl Eugen Hoyos a écrit : >> >> 2017-11-09 9:01 GMT+01:00 pkv.stream : >> >>> 1) there are changes to make to the list of channel layouts not requiring >>> PCE >>> >>> ==> AV_CH_LAYOUT_5POINT0 to AV_CH_LAYOUT_5POINT0_BACK >>> since

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-11-14 Thread pkv.stream
Le 14/11/2017 à 1:20 AM, Carl Eugen Hoyos a écrit : 2017-11-09 9:01 GMT+01:00 pkv.stream : 1) there are changes to make to the list of channel layouts not requiring PCE ==> AV_CH_LAYOUT_5POINT0 to AV_CH_LAYOUT_5POINT0_BACK since the previous is 5.0(side) while the latter is 5.0 which is what i

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-11-13 Thread Carl Eugen Hoyos
2017-11-09 9:01 GMT+01:00 pkv.stream : > 1) there are changes to make to the list of channel layouts not requiring > PCE > > ==> AV_CH_LAYOUT_5POINT0 to AV_CH_LAYOUT_5POINT0_BACK since the previous is > 5.0(side) while the latter is 5.0 which is what is in spec (table 1.19 > ISO/IEC 14496-3:200X(E

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-11-10 Thread Kv Pham
> Hi atomnuker, > > that's wonderful; > > there are two things also: > > 1) there are changes to make to the list of channel layouts not requiring > PCE > > ==> AV_CH_LAYOUT_5POINT0 to AV_CH_LAYOUT_5POINT0_BACK since the previous > is 5.0(side) while the latter is 5.0 which is what is in spec (tabl

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-11-09 Thread Rostislav Pehlivanov
On 9 November 2017 at 08:01, pkv.stream wrote: > Le 09/11/2017 à 4:43 AM, Rostislav Pehlivanov a écrit : > >> On 18 October 2017 at 11:05, pkv.stream wrote: >> >> Le 02/10/2017 à 8:39 PM, Rostislav Pehlivanov a écrit : >>> >>> On 2 October 2017 at 18:43, pkv.stream wrote: Le 02/10/201

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-11-09 Thread pkv.stream
Le 09/11/2017 à 4:43 AM, Rostislav Pehlivanov a écrit : On 18 October 2017 at 11:05, pkv.stream wrote: Le 02/10/2017 à 8:39 PM, Rostislav Pehlivanov a écrit : On 2 October 2017 at 18:43, pkv.stream wrote: Le 02/10/2017 à 7:23 PM, Michael Niedermayer a écrit : On Mon, Oct 02, 2017 at 12:52

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-11-08 Thread Rostislav Pehlivanov
On 18 October 2017 at 11:05, pkv.stream wrote: > Le 02/10/2017 à 8:39 PM, Rostislav Pehlivanov a écrit : > >> On 2 October 2017 at 18:43, pkv.stream wrote: >> >> Le 02/10/2017 à 7:23 PM, Michael Niedermayer a écrit : >>> >>> On Mon, Oct 02, 2017 at 12:52:53AM +0200, pkv.stream wrote: L

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-10-18 Thread pkv.stream
Le 02/10/2017 à 8:39 PM, Rostislav Pehlivanov a écrit : On 2 October 2017 at 18:43, pkv.stream wrote: Le 02/10/2017 à 7:23 PM, Michael Niedermayer a écrit : On Mon, Oct 02, 2017 at 12:52:53AM +0200, pkv.stream wrote: Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit : 2017-10-02 0:40 GM

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-10-02 Thread Rostislav Pehlivanov
On 2 October 2017 at 18:43, pkv.stream wrote: > Le 02/10/2017 à 7:23 PM, Michael Niedermayer a écrit : > >> On Mon, Oct 02, 2017 at 12:52:53AM +0200, pkv.stream wrote: >> >>> Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit : >>> 2017-10-02 0:40 GMT+02:00 pkv.stream : > Hi atomnuk

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-10-02 Thread pkv.stream
Le 02/10/2017 à 7:23 PM, Michael Niedermayer a écrit : On Mon, Oct 02, 2017 at 12:52:53AM +0200, pkv.stream wrote: Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit : 2017-10-02 0:40 GMT+02:00 pkv.stream : Hi atomnuker, got your PCE working; the patch you attached contains tabs, they cannot

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-10-02 Thread Michael Niedermayer
On Mon, Oct 02, 2017 at 12:52:53AM +0200, pkv.stream wrote: > Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit : > >2017-10-02 0:40 GMT+02:00 pkv.stream : > >>Hi atomnuker, > >> > >>got your PCE working; > >the patch you attached contains tabs, they cannot be committed > >to the FFmpeg repository

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-10-01 Thread pkv.stream
forgot to say a few things: - only the order and the type of the element (sce, cpe or lfe) really matters for the encoding; the encoder does not use the front, side or back info; I have used that fact for instance for 7.1 and 7.1(wide) or 7.1(wide-side): same PCE config can be used and works pe

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-10-01 Thread pkv.stream
Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit : 2017-10-02 0:40 GMT+02:00 pkv.stream : Hi atomnuker, got your PCE working; the patch you attached contains tabs, they cannot be committed to the FFmpeg repository, please remove them. (Or one tab.) thanks for pointing out. Removed the offe

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-10-01 Thread Carl Eugen Hoyos
2017-10-02 0:40 GMT+02:00 pkv.stream : > Hi atomnuker, > > got your PCE working; the patch you attached contains tabs, they cannot be committed to the FFmpeg repository, please remove them. (Or one tab.) Thank you, Carl Eugen ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-10-01 Thread pkv.stream
Hi atomnuker, got your PCE working; my previous issues where index related and were the reasons ffmpeg aac decoder would issue errors. So found out: - index is not reset between groups of front, side, back; - it runs actually for each type (SCE, CPE, LFE) - for ffmpeg aac decoder to work, the

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-09-24 Thread pkv.stream
Le 24/09/2017 à 5:06 PM, Rostislav Pehlivanov a écrit : On 24 September 2017 at 15:27, pkv.stream wrote: Hi atomnuker and others I am interested in working on this patch by atomnuker who did a great job. This could allow encoding to more channels with aac (e.g. ambisonics order three = 16 a

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-09-24 Thread Rostislav Pehlivanov
On 24 September 2017 at 15:27, pkv.stream wrote: > Hi atomnuker and others > > I am interested in working on this patch by atomnuker who did a great job. > > This could allow encoding to more channels with aac (e.g. ambisonics order > three = 16 audio channels). > > Here's a report about addition

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-09-24 Thread pkv.stream
link to original thread: http://ffmpeg.org/pipermail/ffmpeg-devel/2016-October/200566.html ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-09-24 Thread pkv.stream
Hi atomnuker and others I am interested in working on this patch by atomnuker who did a great job. This could allow encoding to more channels with aac (e.g. ambisonics order three = 16 audio channels). Here's a report about additions I made to the PCE table for all the basic ffmpeg channel l

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2016-10-03 Thread Claudio Freire
On Mon, Oct 3, 2016 at 3:53 PM, Rostislav Pehlivanov wrote: > Hopefully whoever wants to have support for crazy formats can help. > The table in aacenc.h (temporary position) tells the encoder what > to put in the bitstream and how to encode. Problem is, the specifications > dont specify anything.