Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-25 Thread Mohammad Izadi
On Tue, Feb 25, 2020, 9:32 PM Vittorio Giovara wrote: > On Tue, Feb 25, 2020 at 9:16 PM Mohammad Izadi > wrote: > > > On Mon, Feb 24, 2020 at 9:56 AM Vittorio Giovara < > > vittorio.giov...@gmail.com> > > wrote: > > > > > On Sat, Feb 22, 2020 at 12:44 PM Mohammad Izadi > > > wrote: > > > > > >

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-25 Thread Vittorio Giovara
On Tue, Feb 25, 2020 at 9:16 PM Mohammad Izadi wrote: > On Mon, Feb 24, 2020 at 9:56 AM Vittorio Giovara < > vittorio.giov...@gmail.com> > wrote: > > > On Sat, Feb 22, 2020 at 12:44 PM Mohammad Izadi > > wrote: > > > > > On Fri, Feb 21, 2020, 6:44 PM Vittorio Giovara < > > vittorio.giov...@gmail

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-25 Thread Mohammad Izadi
On Mon, Feb 24, 2020 at 9:56 AM Vittorio Giovara wrote: > On Sat, Feb 22, 2020 at 12:44 PM Mohammad Izadi > wrote: > > > On Fri, Feb 21, 2020, 6:44 PM Vittorio Giovara < > vittorio.giov...@gmail.com > > > > > wrote: > > > > > On Fri, Feb 21, 2020 at 5:17 PM Mohammad Izadi > > > wrote: > > > > >

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-24 Thread Vittorio Giovara
On Sat, Feb 22, 2020 at 12:44 PM Mohammad Izadi wrote: > On Fri, Feb 21, 2020, 6:44 PM Vittorio Giovara > > wrote: > > > On Fri, Feb 21, 2020 at 5:17 PM Mohammad Izadi > > wrote: > > > > > Why does the struct belong to lavu? This struct is super similar to > > structs > > > in libavcodec/hevc_s

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-22 Thread Mohammad Izadi
On Fri, Feb 21, 2020, 6:44 PM Vittorio Giovara wrote: > On Fri, Feb 21, 2020 at 5:17 PM Mohammad Izadi > wrote: > > > Why does the struct belong to lavu? This struct is super similar to > structs > > in libavcodec/hevc_sei.h. We just move it to a new file to share it > between > > hevc and vp9 e

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-21 Thread Vittorio Giovara
On Fri, Feb 21, 2020 at 5:17 PM Mohammad Izadi wrote: > Why does the struct belong to lavu? This struct is super similar to structs > in libavcodec/hevc_sei.h. We just move it to a new file to share it between > hevc and vp9 encoder/decoder. > > -- > 1. Please kindly stop top posting: http://www

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-21 Thread Mohammad Izadi
Why does the struct belong to lavu? This struct is super similar to structs in libavcodec/hevc_sei.h. We just move it to a new file to share it between hevc and vp9 encoder/decoder. -- Best, Mohammad On Fri, Feb 21, 2020 at 2:03 PM Hendrik Leppkes wrote: > On Fri, Feb 21, 2020 at 7:08 PM Moham

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-21 Thread Hendrik Leppkes
On Fri, Feb 21, 2020 at 7:08 PM Mohammad Izadi wrote: > > If you believe lavc is at the top of the hierarchy, I can simply move the > file to lavc. Then both lavc and lavf can use it and hierarchy is > respected. Can I do that? Doesn't break API? Any objection (with solution)? > Let's make right d

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-21 Thread Mohammad Izadi
If you believe lavc is at the top of the hierarchy, I can simply move the file to lavc. Then both lavc and lavf can use it and hierarchy is respected. Can I do that? Doesn't break API? Any objection (with solution)? Let's make right decisions to speed up the process please :). -- Best, Mohammad O

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-21 Thread Hendrik Leppkes
On Fri, Feb 21, 2020 at 5:59 AM Vittorio Giovara wrote: > > On Thu, Feb 20, 2020 at 6:38 PM James Almer wrote: > > > On 2/20/2020 5:02 PM, Vittorio Giovara wrote: > > > On Mon, Feb 10, 2020 at 3:14 PM Mohammad Izadi > > wrote: > > > > > >> From: Mohammad Izadi > > >> > > >> Trying to read HDR10

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-21 Thread Nicolas George
Vittorio Giovara (12020-02-20): > bacuase lavf is a library which depends on lavc, not vice versa, hierarchy > is respected > > I still consider it a poor design choice The poor design choice is to keep the libraries separated. We can see all the trouble it causes us, between this discussion and

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-20 Thread Vittorio Giovara
On Thu, Feb 20, 2020 at 6:38 PM James Almer wrote: > On 2/20/2020 5:02 PM, Vittorio Giovara wrote: > > On Mon, Feb 10, 2020 at 3:14 PM Mohammad Izadi > wrote: > > > >> From: Mohammad Izadi > >> > >> Trying to read HDR10+ metadata from HEVC/SEI and pass it to packet side > >> data in the follow-

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-20 Thread James Almer
On 2/20/2020 5:02 PM, Vittorio Giovara wrote: > On Mon, Feb 10, 2020 at 3:14 PM Mohammad Izadi wrote: > >> From: Mohammad Izadi >> >> Trying to read HDR10+ metadata from HEVC/SEI and pass it to packet side >> data in the follow-up CLs. >> --- >> libavutil/hdr_dynamic_metadata.c | 165 ++

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-20 Thread Vittorio Giovara
On Thu, Feb 20, 2020 at 3:16 PM Mohammad Izadi wrote: > On Thu, Feb 20, 2020 at 12:10 PM Vittorio Giovara < > vittorio.giov...@gmail.com> wrote: > > > On Mon, Feb 10, 2020 at 3:14 PM Mohammad Izadi > > wrote: > > > > > From: Mohammad Izadi > > > > > > Trying to read HDR10+ metadata from HEVC/SE

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-20 Thread Mohammad Izadi
On Thu, Feb 20, 2020 at 12:10 PM Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > On Mon, Feb 10, 2020 at 3:14 PM Mohammad Izadi > wrote: > > > From: Mohammad Izadi > > > > Trying to read HDR10+ metadata from HEVC/SEI and pass it to packet side > > data in the follow-up CLs. > > --- > >

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-20 Thread Vittorio Giovara
On Mon, Feb 10, 2020 at 3:14 PM Mohammad Izadi wrote: > From: Mohammad Izadi > > Trying to read HDR10+ metadata from HEVC/SEI and pass it to packet side > data in the follow-up CLs. > --- > libavutil/hdr_dynamic_metadata.c | 165 +++ > libavutil/hdr_dynamic_metadata.

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-19 Thread Mohammad Izadi
On Wed, Feb 19, 2020 at 4:22 PM Mark Thompson wrote: > On 10/02/2020 19:38, Mohammad Izadi wrote: > > On Sun, Feb 9, 2020 at 8:31 AM Mark Thompson wrote: > > > >> On 07/02/2020 17:46, Mohammad Izadi wrote: > >>> From: Mohammad Izadi > >>> > >>> Trying to read HDR10+ metadata from HEVC/SEI and p

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-19 Thread Mark Thompson
On 10/02/2020 19:38, Mohammad Izadi wrote: > On Sun, Feb 9, 2020 at 8:31 AM Mark Thompson wrote: > >> On 07/02/2020 17:46, Mohammad Izadi wrote: >>> From: Mohammad Izadi >>> >>> Trying to read HDR10+ metadata from HEVC/SEI and pass it to packet side >> data in the follow-up CLs. >>> --- >>> lib

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-19 Thread Derek Buitenhuis
On 19/02/2020 18:25, Mohammad Izadi wrote: > The comment was wrong. Thanks for clarifying! - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-19 Thread Mohammad Izadi
The comment was wrong. -- Best, Mohammad On Wed, Feb 19, 2020 at 7:22 AM Derek Buitenhuis wrote: > On 10/02/2020 19:44, Mohammad Izadi wrote: > > /** > > * The nominal maximum display luminance of the targeted system > display, > > - * in units of 0.0001 candelas per square metre

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-19 Thread Derek Buitenhuis
On 10/02/2020 19:44, Mohammad Izadi wrote: > /** > * The nominal maximum display luminance of the targeted system display, > - * in units of 0.0001 candelas per square metre. The value shall be in > + * in units of 1 candelas per square metre. The value shall be in > * the

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-18 Thread Mohammad Izadi
Hello, What's the status of the cl review? Is it good to submit? -- Best, Mohammad On Mon, Feb 10, 2020 at 11:44 AM Mohammad Izadi wrote: > From: Mohammad Izadi > > Trying to read HDR10+ metadata from HEVC/SEI and pass it to packet side > data in the follow-up CLs. > --- > libavutil/hdr_dyna

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-10 Thread Mohammad Izadi
On Sun, Feb 9, 2020 at 8:31 AM Mark Thompson wrote: > On 07/02/2020 17:46, Mohammad Izadi wrote: > > From: Mohammad Izadi > > > > Trying to read HDR10+ metadata from HEVC/SEI and pass it to packet side > data in the follow-up CLs. > > --- > > libavutil/hdr_dynamic_metadata.c | 165 +

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-09 Thread Mark Thompson
On 07/02/2020 17:46, Mohammad Izadi wrote: > From: Mohammad Izadi > > Trying to read HDR10+ metadata from HEVC/SEI and pass it to packet side data > in the follow-up CLs. > --- > libavutil/hdr_dynamic_metadata.c | 165 +++ > libavutil/hdr_dynamic_metadata.h | 12 ++-

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-05 Thread Mohammad Izadi
Please check my responses inline: On Wed, Feb 5, 2020 at 5:48 AM Moritz Barsnick wrote: > Hi Mohammad, > > On Tue, Feb 04, 2020 at 18:44:00 -0800, Mohammad Izadi wrote: > > --- a/libavutil/hdr_dynamic_metadata.c > > +++ b/libavutil/hdr_dynamic_metadata.c > > @@ -1,4 +1,4 @@ > > -/** > > + /** >

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-05 Thread Moritz Barsnick
Hi Mohammad, On Tue, Feb 04, 2020 at 18:44:00 -0800, Mohammad Izadi wrote: > --- a/libavutil/hdr_dynamic_metadata.c > +++ b/libavutil/hdr_dynamic_metadata.c > @@ -1,4 +1,4 @@ > -/** > + /** Please review your git diff and your submitted patches carefully. You need to avoid this accidental change.

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-03 Thread Mohammad Izadi
Great! Thanks! On Mon, Feb 3, 2020, 6:37 PM James Almer wrote: > On 2/3/2020 11:01 PM, Mohammad Izadi wrote: > > James, I am making another CL to comply with API. > > I have a question about using GetBitContext and PutBitContext. Is there > any > > alternative to use in libavutil? > > You can us

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-03 Thread James Almer
On 2/3/2020 11:01 PM, Mohammad Izadi wrote: > James, I am making another CL to comply with API. > I have a question about using GetBitContext and PutBitContext. Is there any > alternative to use in libavutil? You can use it in libavutil as long as it's not part of the public API. So you should mak

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-02-03 Thread Mohammad Izadi
James, I am making another CL to comply with API. I have a question about using GetBitContext and PutBitContext. Is there any alternative to use in libavutil? -- Best, Mohammad On Mon, Jan 27, 2020 at 11:50 AM James Almer wrote: > On 1/27/2020 4:08 PM, Mohammad Izadi wrote: > > From: Mohammad I

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-01-27 Thread Carl Eugen Hoyos
Am Mo., 27. Jan. 2020 um 21:02 Uhr schrieb Mohammad Izadi : > I created this metadata 6 months ago to use it at YouTube. The metadata is > incomplete here. I already implemented HDR10+ for our local ffmpeg and > trying to push them to the head. > Please note that the current code of HDR10+ is not

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-01-27 Thread Mohammad Izadi
Hey Carl, I created this metadata 6 months ago to use it at YouTube. The metadata is incomplete here. I already implemented HDR10+ for our local ffmpeg and trying to push them to the head. Please note that the current code of HDR10+ is not working. On Mon, Jan 27, 2020, 11:44 AM Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-01-27 Thread James Almer
On 1/27/2020 4:08 PM, Mohammad Izadi wrote: > From: Mohammad Izadi > > Trying to read HDR10+ metadata from HEVC/SEI and pass it to packet side data > in the follow-up CLs. > --- > libavutil/hdr_dynamic_metadata.c | 386 +++ > libavutil/hdr_dynamic_metadata.h | 51 ++

Re: [FFmpeg-devel] [PATCH] Update HDR10+ metadata structure.

2020-01-27 Thread Carl Eugen Hoyos
Am Mo., 27. Jan. 2020 um 20:34 Uhr schrieb Mohammad Izadi : > /** > * Allocate an AVDynamicHDRPlus structure and set its fields to > * default values. The resulting struct can be freed using av_freep(). > + * @param gb The input bit stream. > + * @param size The size of allocated memory for t