Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-14 Thread Joakim Tjernlund
On Tue, 2020-10-13 at 20:33 +0200, Joakim Tjernlund wrote: > On Tue, 2020-10-13 at 20:11 +0200, Andreas Rheinhardt wrote: > > > > Joakim Tjernlund: > > > On Tue, 2020-10-13 at 15:24 +0100, Derek Buitenhuis wrote: > > > > > > > > On 13/10/2020 15:19, Joakim Tjernlund wrote: > > > > > For now just

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Joakim Tjernlund
On Tue, 2020-10-13 at 20:11 +0200, Andreas Rheinhardt wrote: > > Joakim Tjernlund: > > On Tue, 2020-10-13 at 15:24 +0100, Derek Buitenhuis wrote: > > > > > > On 13/10/2020 15:19, Joakim Tjernlund wrote: > > > > For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is > > > > beyond

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Andreas Rheinhardt
Joakim Tjernlund: > On Tue, 2020-10-13 at 15:24 +0100, Derek Buitenhuis wrote: >> >> On 13/10/2020 15:19, Joakim Tjernlund wrote: >>> For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is >>> beyond this patch. >> >> As Ronald mentioned, if you're going to fix the ABI/API, you sho

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Joakim Tjernlund
On Tue, 2020-10-13 at 14:03 -0300, James Almer wrote: > > > On 10/13/2020 11:24 AM, Derek Buitenhuis wrote: > > On 13/10/2020 15:19, Joakim Tjernlund wrote: > > > For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is > > > beyond this patch. > > > > As Ronald mentioned, if you'

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread James Almer
On 10/13/2020 11:24 AM, Derek Buitenhuis wrote: > On 13/10/2020 15:19, Joakim Tjernlund wrote: >> For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is >> beyond this patch. > > As Ronald mentioned, if you're going to fix the ABI/API, you should actually > fix every use of that A

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Joakim Tjernlund
On Tue, 2020-10-13 at 15:24 +0100, Derek Buitenhuis wrote: > > On 13/10/2020 15:19, Joakim Tjernlund wrote: > > For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is > > beyond this patch. > > As Ronald mentioned, if you're going to fix the ABI/API, you should actually > fix eve

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Derek Buitenhuis
On 13/10/2020 15:19, Joakim Tjernlund wrote: > For now just fixing av_malloc_max(0) will do, av_max_malloc2() etc. is beyond > this patch. As Ronald mentioned, if you're going to fix the ABI/API, you should actually fix every use of that ABI/API, not just the one you care about (0). So max value

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Joakim Tjernlund
On Tue, 2020-10-13 at 09:41 -0400, Ronald S. Bultje wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > Hi, > > On Tue, Oct 13, 2020 at 6:30 AM Joakim Tjernlund >

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Ronald S. Bultje
Hi, On Tue, Oct 13, 2020 at 6:30 AM Joakim Tjernlund < joakim.tjernl...@infinera.com> wrote: > From https://bugs.chromium.org/p/chromium/issues/detail?id=1095962 > > This seems to be caused by the custom handling of "av_max_alloc(0)" in > Chromium's ffmpeg fork to mea