Re: [FFmpeg-devel] [PATCH] Save FFmpeg colorspace info in openh264 video files.

2016-12-13 Thread Michael Niedermayer
On Fri, Dec 09, 2016 at 01:15:14PM -0500, Gregory J. Wolfe wrote: > As of version 1.6, libopenh264 saves (in the output video file) > information about the color primaries, transfer characteristics, > and color matrix used when the video pixel data was created. > This patch sets the required libope

Re: [FFmpeg-devel] [PATCH] Save FFmpeg colorspace info in openh264 video files.

2016-12-02 Thread Gregory J Wolfe
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On > Behalf Of James Almer > Sent: Friday, December 02, 2016 9:31 AM > > On 12/1/2016 6:26 PM, Gregory J. Wolfe wrote: > > As of version 1.6, libopenh264 saves (in the output video file) > > information about the color primaries, transf

Re: [FFmpeg-devel] [PATCH] Save FFmpeg colorspace info in openh264 video files.

2016-12-02 Thread James Almer
On 12/1/2016 6:26 PM, Gregory J. Wolfe wrote: > As of version 1.6, libopenh264 saves (in the output video file) > information about the color primaries, transfer characteristics, > and color matrix used when the video pixel data was created. > This patch sets the required libopenh264 data structure

Re: [FFmpeg-devel] [PATCH] Save FFmpeg colorspace info in openh264 video files.

2016-12-02 Thread Gregory J Wolfe
> > +switch (avctx->color_primaries) { > > +case AVCOL_PRI_BT709: > param.sSpatialLayers[0].uiColorPrimaries = CP_BT709; break; > > +case AVCOL_PRI_UNSPECIFIED: > param.sSpatialLayers[0].uiColorPrimaries = CP_UNDEF; break; > > [ignore] > Please align v

Re: [FFmpeg-devel] [PATCH] Save FFmpeg colorspace info in openh264 video files.

2016-12-01 Thread Ronald S. Bultje
Hi, On Thu, Dec 1, 2016 at 6:35 PM, Carl Eugen Hoyos wrote: > 2016-12-01 22:26 GMT+01:00 Gregory J. Wolfe >: > > > +switch (avctx->color_primaries) { > > +case AVCOL_PRI_BT709:param.sSpatialLayers[0].uiColorPrimaries > = CP_BT709; break; > > +case AVCOL_PRI_U

Re: [FFmpeg-devel] [PATCH] Save FFmpeg colorspace info in openh264 video files.

2016-12-01 Thread Carl Eugen Hoyos
2016-12-01 22:26 GMT+01:00 Gregory J. Wolfe : > +switch (avctx->color_primaries) { > +case AVCOL_PRI_BT709:param.sSpatialLayers[0].uiColorPrimaries > = CP_BT709; break; > +case AVCOL_PRI_UNSPECIFIED: param.sSpatialLayers[0].uiColorPrimaries > = CP_U

Re: [FFmpeg-devel] [PATCH] Save FFmpeg colorspace info in openh264 video files.

2016-11-28 Thread Carl Eugen Hoyos
2016-11-28 23:25 GMT+01:00 Gregory J. Wolfe : > This patch sets the required libopenh264 data structures using > the FFmpeg colorspace information so that video players will > know how to properly decode video files created using FFmpeg > and libopenh264. Please copy FFmpeg's switch() style from