Re: [FFmpeg-devel] [PATCH] Mark .rodata section as read only in COFF object file

2019-01-14 Thread Tom Tan
Tan Sent: Friday, January 11, 2019 11:38 AM To: FFmpeg development discussions and patches Cc: Martin Storsjö Subject: Re: [FFmpeg-devel] [PATCH] Mark .rodata section as read only in COFF object file Thanks Carl. Martin made a better fix when porting this to libav which uses .rdata as section

Re: [FFmpeg-devel] [PATCH] Mark .rodata section as read only in COFF object file

2019-01-11 Thread Tom Tan
: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Mark .rodata section as read only in COFF object file 2019-01-10 21:14 GMT+01:00, Tom Tan : > .rodata directive from GAS assembly produces .rodata as read/write for > COFF object file by default (object file form

Re: [FFmpeg-devel] [PATCH] Mark .rodata section as read only in COFF object file

2019-01-11 Thread Carl Eugen Hoyos
2019-01-10 21:14 GMT+01:00, Tom Tan : > .rodata directive from GAS assembly produces .rodata as read/write for COFF > object file by default (object file format for Windows), but read only for > ELF. This change marks it as read only explicitly for COFF. > > The issue happens when building Chromium