Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-22 Thread Michael Niedermayer
On Sun, Aug 20, 2017 at 11:56:47AM -0700, Vitaly Buka wrote: > Signed integer overflow is undefined behavior. > Detected with clang and -fsanitize=signed-integer-overflow > > Signed-off-by: Vitaly Buka > --- > libavcodec/utils.c| 2 +- > libavformat/aviobuf.c | 2 ++ > libavformat/mov.c

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-22 Thread James Almer
On 8/22/2017 2:30 PM, Paul B Mahol wrote: > On 8/22/17, Vitaly Buka wrote: >> What else can I do yo make it accepted? > > Ping it after month or two? A week is enough wait to justify a ping. A month is overkill. > >> >> On Sun, Aug 20, 2017 at 11:56 AM, Vitaly Buka wrote: >> >>> Signed intege

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-22 Thread Paul B Mahol
On 8/22/17, Vitaly Buka wrote: > What else can I do yo make it accepted? Ping it after month or two? > > On Sun, Aug 20, 2017 at 11:56 AM, Vitaly Buka wrote: > >> Signed integer overflow is undefined behavior. >> Detected with clang and -fsanitize=signed-integer-overflow >> >> Signed-off-by: Vi

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-22 Thread Vitaly Buka
What else can I do yo make it accepted? On Sun, Aug 20, 2017 at 11:56 AM, Vitaly Buka wrote: > Signed integer overflow is undefined behavior. > Detected with clang and -fsanitize=signed-integer-overflow > > Signed-off-by: Vitaly Buka > --- > libavcodec/utils.c| 2 +- > libavformat/aviobuf.

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-20 Thread James Almer
On 8/20/2017 4:10 AM, Vitaly Buka wrote: > Looks like libavcodec/ has more LL or ll than INT64_C. > Should I update the patch? IMO yes. LL is known to work whereas ll might not in some fringe setups (we have a few of those running FATE). > > On Sat, Aug 19, 2017 at 11:35 PM, Hendrik Leppkes > w

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-20 Thread Vitaly Buka
Looks like libavcodec/ has more LL or ll than INT64_C. Should I update the patch? On Sat, Aug 19, 2017 at 11:35 PM, Hendrik Leppkes wrote: > On Sun, Aug 20, 2017 at 3:19 AM, Vitaly Buka > wrote: > > Signed integer overflow is undefined behavior. > > Detected with clang and -fsanitize=signed-int

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-19 Thread Hendrik Leppkes
On Sun, Aug 20, 2017 at 3:19 AM, Vitaly Buka wrote: > Signed integer overflow is undefined behavior. > Detected with clang and -fsanitize=signed-integer-overflow > > Signed-off-by: Vitaly Buka > --- > libavcodec/utils.c| 2 +- > libavformat/aviobuf.c | 2 ++ > libavformat/mov.c | 2 +- >

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-19 Thread Michael Niedermayer
On Thu, Aug 17, 2017 at 11:14:47PM -0700, Vitaly Buka wrote: > Signed integer overflow is undefined behavior. > Detected with clang and -fsanitize=signed-integer-overflow > > Signed-off-by: Vitaly Buka > --- > libavcodec/utils.c| 2 +- > libavformat/aviobuf.c | 4 +++- > libavformat/mov.c

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-18 Thread Vitaly Buka
Not sure or it's going to be very hard for me. third_party/ffmpeg/LGPL_pristine/libavformat/aviobuf.c:225:16 Error was: mov.c:3961:23: runtime error: signed integer overflow: 9223372036854775807 + 8 cannot be represented in type 'long' On Fri, Aug 18, 2017 at 1:13 AM, Carl Eugen Hoyos wrote: >

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-18 Thread Vitaly Buka
On Fri, Aug 18, 2017 at 1:11 AM, Tomas Härdin wrote: > On 2017-08-18 08:14, Vitaly Buka wrote: > >> Signed integer overflow is undefined behavior. >> Detected with clang and -fsanitize=signed-integer-overflow >> >> Signed-off-by: Vitaly Buka >> --- >> libavcodec/utils.c| 2 +- >> libavfor

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-18 Thread Carl Eugen Hoyos
2017-08-18 8:14 GMT+02:00 Vitaly Buka : > Signed integer overflow is undefined behavior. > Detected with clang and -fsanitize=signed-integer-overflow > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -5572,7 +5572,7 @@ static int mov_read_default(MOVContext *c, AVIOContext > *pb, MOVAtom a

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-18 Thread Tomas Härdin
On 2017-08-18 08:14, Vitaly Buka wrote: Signed integer overflow is undefined behavior. Detected with clang and -fsanitize=signed-integer-overflow Signed-off-by: Vitaly Buka --- libavcodec/utils.c| 2 +- libavformat/aviobuf.c | 4 +++- libavformat/mov.c | 2 +- 3 files changed, 5 in