Re: [FFmpeg-devel] [PATCH] Add support for large boxes(>32 bit)

2015-05-22 Thread Philip Langdale
On Thu, 21 May 2015 21:45:52 +0530 Niklesh Lalwani wrote: > Updated patch. > > Thanks, > > Niklesh Pushed. Thanks. --phil ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(>32 bit)

2015-05-21 Thread Niklesh Lalwani
Updated patch. Thanks, Niklesh 3gpp-largeboxes-21may.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(>32 bit)

2015-05-21 Thread Niklesh Lalwani
Yes, that would be good. Thanks. -Niklesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(>32 bit)

2015-05-21 Thread Philip Langdale
On Thu, 21 May 2015 18:51:20 +0530 Niklesh Lalwani wrote: > Do you mean using a variable equal to tracksize + 10/18? That > wouldn't be of much use imo. No, a variable equal to 10 or 18, depending. Then you don't need code that does one check if it's a large box and another if it isn't. --phil

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(>32 bit)

2015-05-21 Thread Niklesh Lalwani
Do you mean using a variable equal to tracksize + 10/18? That wouldn't be of much use imo. -Niklesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(>32 bit)

2015-05-20 Thread Philip Langdale
On 2015-05-20 13:13, Niklesh Lalwani wrote: From: Niklesh Signed-off-by: Niklesh --- libavcodec/movtextdec.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index 53ffef0..6ff02b3 100644 --- a/libavcod

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(>32 bit)

2015-05-20 Thread Niklesh Lalwani
Thanks. I'll do it separately for style entries. -Niklesh On 20-May-2015 11:41 PM, "Philip Langdale" wrote: > On 2015-05-20 11:06, Niklesh Lalwani wrote: > >> I have done tracksize += 8 if there is a large box. This should account >> for >> it? >> > > I see you did, but that's not a good idea. P

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(>32 bit)

2015-05-20 Thread Philip Langdale
On 2015-05-20 11:06, Niklesh Lalwani wrote: I have done tracksize += 8 if there is a large box. This should account for it? I see you did, but that's not a good idea. Previously, tracksize was accurate, in that it reflected adding tsmb_size each time. Now you're adding 8 that's already inclu

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(>32 bit)

2015-05-20 Thread Niklesh Lalwani
I have done tracksize += 8 if there is a large box. This should account for it? On 20-May-2015 11:17 PM, "Philip Langdale" wrote: > On 2015-05-20 07:40, Niklesh Lalwani wrote: > >> From: Niklesh >> >> This patch is to be applied over the previous patch to fix movtext >> crashes (which is yet to

Re: [FFmpeg-devel] [PATCH] Add support for large boxes(>32 bit)

2015-05-20 Thread Philip Langdale
On 2015-05-20 07:40, Niklesh Lalwani wrote: From: Niklesh This patch is to be applied over the previous patch to fix movtext crashes (which is yet to be committed) Signed-off-by: Niklesh --- libavcodec/movtextdec.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git