Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-16 Thread Marton Balint
On Fri, 14 May 2021, Dominguez Bonini, David wrote: Hi, Hi Marton, Il 2021-05-12 19:18 Marton Balint ha scritto: On Wed, 12 May 2021, Ubaldo Porcheddu wrote: Hi Marton, +} + +//private data +desc_len += 6 + 2; +*q++ = 0x5F; +*q++ = 4; +*q++ = 0x00; +*q++ =

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-14 Thread Ubaldo Porcheddu
Hola David, thank you for clarifying it, maybe we leave 0x28 by default and add a "nit_private" option for: none, NorDig, UK ? Here is the function so far: +static void mpegts_write_nit(AVFormatContext *s) +{ +int i, lcn_count=0; +MpegTSWrite *ts = s->priv_data; +uint8_t data[SECT

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-14 Thread Dominguez Bonini, David
Hi, > Hi Marton, > > Il 2021-05-12 19:18 Marton Balint ha scritto: > > On Wed, 12 May 2021, Ubaldo Porcheddu wrote: > > > >> Hi Marton, > >> > +} > + > +//private data > +desc_len += 6 + 2; > +*q++ = 0x5F; > +*q++ = 4; > +*q++ = 0x00; > >

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-14 Thread Ubaldo Porcheddu
Hi Marton, Il 2021-05-12 19:18 Marton Balint ha scritto: On Wed, 12 May 2021, Ubaldo Porcheddu wrote: Hi Marton, +} + +//private data +desc_len += 6 + 2; +*q++ = 0x5F; +*q++ = 4; +*q++ = 0x00; +*q++ = 0x00; +put16(&q, 40); What are these? I didn't find any

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-12 Thread Marton Balint
On Wed, 12 May 2021, Ubaldo Porcheddu wrote: Hi Marton, +} + +//private data +desc_len += 6 + 2; +*q++ = 0x5F; +*q++ = 4; +*q++ = 0x00; +*q++ = 0x00; +put16(&q, 40); What are these? I didn't find any official document about it but this seems to be the way

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-12 Thread Ubaldo Porcheddu
Hi Marton, +} + +//private data +desc_len += 6 + 2; +*q++ = 0x5F; +*q++ = 4; +*q++ = 0x00; +*q++ = 0x00; +put16(&q, 40); What are these? I didn't find any official document about it but this seems to be the way many national (FR,IT,UK) broadcasters are writin

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-02 Thread Marton Balint
On Tue, 27 Apr 2021, Ubaldo Porcheddu wrote: Signed-off-by: Ubaldo Porcheddu --- libavformat/mpegtsenc.c | 110 ++-- 1 file changed, 106 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index a357f3a6aa..