Re: [FFmpeg-devel] [PATCH] Add max value output option to psnr stats log.

2016-09-01 Thread Michael Niedermayer
On Wed, Aug 31, 2016 at 12:40:41PM -0700, Lucas Cooper wrote: > This allows retroactive calculation/aggregation of PSNR from the stats > log. > --- > doc/filters.texi | 10 ++ > libavfilter/vf_psnr.c | 20 > 2 files changed, 30 insertions(+) applied thx [...] -

Re: [FFmpeg-devel] [PATCH] Add max value output option to psnr stats log.

2016-08-29 Thread Michael Niedermayer
On Mon, Aug 29, 2016 at 01:12:10PM -0700, Lucas Cooper wrote: > > if the user sets output_max without stats_version 2 this would just > silently ignore the option > > Do you think this warrants a fatal error? A warning seems insufficient as > the output_max option is explicitly requested by the us

Re: [FFmpeg-devel] [PATCH] Add max value output option to psnr stats log.

2016-08-29 Thread Lucas Cooper
> if the user sets output_max without stats_version 2 this would just silently ignore the option Do you think this warrants a fatal error? A warning seems insufficient as the output_max option is explicitly requested by the user. > also missing doc/*.texi update Should I send that in a followup

Re: [FFmpeg-devel] [PATCH] Add max value output option to psnr stats log.

2016-08-27 Thread Michael Niedermayer
On Fri, Aug 26, 2016 at 12:10:17PM -0700, Lucas Cooper wrote: > This allows retroactive calculation/aggregation of PSNR from the stats > log. > --- > libavfilter/vf_psnr.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/libavfilter/vf_psnr.c b/libavfilter/vf_psnr.c > ind

Re: [FFmpeg-devel] [PATCH] Add max value output option to psnr stats log.

2016-08-17 Thread Michael Niedermayer
On Thu, Aug 11, 2016 at 10:44:12AM -0700, Lucas Cooper wrote: > This allows retroactive calculation/aggregation of PSNR from the stats > log. > --- > libavfilter/vf_psnr.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/libavfilter/vf_psnr.c b/libavfilter/vf_psnr.c > ind