Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-09-01 Thread Michael Niedermayer
On Tue, Aug 31, 2021 at 10:44:57PM +0300, Martin Storsjö wrote: > > On Aug 23, 2021, at 17:41, Nicolas George wrote: > > > > Michael Niedermayer (12021-08-23): > >> Please make sure you use g...@git.ffmpeg.org:fateserver not > >> g...@source.ffmpeg.org:fateserver > > > > My bad. I fixed it and i

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-31 Thread Martin Storsjö
> On Aug 23, 2021, at 17:41, Nicolas George wrote: > > Michael Niedermayer (12021-08-23): >> Please make sure you use g...@git.ffmpeg.org:fateserver not >> g...@source.ffmpeg.org:fateserver > > My bad. I fixed it and it worked. Thanks for looking into these issues and bringing the fate site bac

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Nicolas George
Michael Niedermayer (12021-08-23): > Please make sure you use g...@git.ffmpeg.org:fateserver not > g...@source.ffmpeg.org:fateserver My bad. I fixed it and it worked. Thanks. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Michael Niedermayer
On Mon, Aug 23, 2021 at 04:32:02PM +0200, Nicolas George wrote: > Michael Niedermayer (12021-08-23): > > you should have write access to g...@git.ffmpeg.org:fateserver > > i see this key there: > > 4096 SHA256:JMjmh7/1eynBVRAprwk96+NfcFjmla4v/G/IlwVuuxQ cigaes@ssecem (RSA) > > ~/prog/fateserver $

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Nicolas George
Michael Niedermayer (12021-08-23): > you should have write access to g...@git.ffmpeg.org:fateserver > i see this key there: > 4096 SHA256:JMjmh7/1eynBVRAprwk96+NfcFjmla4v/G/IlwVuuxQ cigaes@ssecem (RSA) ~/prog/fateserver $ git fetch origin-ssh ERROR:gitosis.serve.main:Repository read access denied

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Michael Niedermayer
On Mon, Aug 23, 2021 at 02:18:03PM +0200, Nicolas George wrote: > Nicolas George (12021-08-23): > > I will try to deploy the changes this shortly. > > To deploy the changes cleanly, I would need write access to the > fateserver Git repository. I already have access to the FATE server > itself, but

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread James Almer
On 8/23/2021 9:51 AM, Nicolas George wrote: James Almer (12021-08-23): Assuming it's from 20.04.x to 20.04.2, it should be fine. But shouldn't this It is a bit older than that: Welcome to Ubuntu 18.04.5 LTS (GNU/Linux 4.15.0-151-generic x86_64) That makes it all the more necessary but also a

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Nicolas George
James Almer (12021-08-23): > Assuming it's from 20.04.x to 20.04.2, it should be fine. But shouldn't this It is a bit older than that: Welcome to Ubuntu 18.04.5 LTS (GNU/Linux 4.15.0-151-generic x86_64) That makes it all the more necessary but also all the more risky. > kind of thing be done by

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread James Almer
On 8/23/2021 9:20 AM, Nicolas George wrote: Nicolas George (12021-08-23): To deploy the changes cleanly, I would need write access to the fateserver Git repository. I already have access to the FATE server itself, but not the public repository. Any objection to me doing: New release '20.04.2

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Nicolas George
Nicolas George (12021-08-23): > To deploy the changes cleanly, I would need write access to the > fateserver Git repository. I already have access to the FATE server > itself, but not the public repository. Any objection to me doing: New release '20.04.2 LTS' available. Run 'do-release-upgrade' t

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Nicolas George
Nicolas George (12021-08-23): > I will try to deploy the changes this shortly. To deploy the changes cleanly, I would need write access to the fateserver Git repository. I already have access to the FATE server itself, but not the public repository. Thanks in advance. -- Nicolas George sign

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Nicolas George
Chad Fraleigh (12021-08-22): > It mostly looks good (from a perl perspective). Thanks for the comments. > > Just 3 questionable items.. > > -<>-<>- > > -if ($ENV{HTTP_ACCEPT_ENCODING} =~ /gzip/) { > -print "Content-Encoding: gzip\r\n"; > +if (ready_for_gzip) { > $cat = 'cat'; > } >

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-22 Thread Michael Niedermayer
On Sun, Aug 22, 2021 at 01:35:26PM -0700, Chad Fraleigh wrote: > On 8/22/2021 11:18 AM, Michael Niedermayer wrote: > > On Sun, Aug 15, 2021 at 11:24:47AM +0200, Nicolas George wrote: > > > Nicolas George (12021-08-08): > > > > Here is a patch series for fateserver, to fix warnings and enable Perl's

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-22 Thread Chad Fraleigh
On 8/22/2021 11:18 AM, Michael Niedermayer wrote: On Sun, Aug 15, 2021 at 11:24:47AM +0200, Nicolas George wrote: Nicolas George (12021-08-08): Here is a patch series for fateserver, to fix warnings and enable Perl's taint checks, thus protecting against a whole class of security issues. I wo

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-22 Thread Michael Niedermayer
On Sun, Aug 15, 2021 at 11:24:47AM +0200, Nicolas George wrote: > Nicolas George (12021-08-08): > > Here is a patch series for fateserver, to fix warnings and enable Perl's > > taint checks, thus protecting against a whole class of security issues. > > I would appreciate somebody looks at the code

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-15 Thread Nicolas George
Nicolas George (12021-08-08): > Here is a patch series for fateserver, to fix warnings and enable Perl's > taint checks, thus protecting against a whole class of security issues. I would appreciate somebody looks at the code before I deploy it and we re-enable the server. Regards, -- Nicolas