Re: [FFmpeg-devel] tsan warning about a data race in libavcodec/h264_direct.c

2017-07-20 Thread Wan-Teh Chang
Hi Ronald, On Wed, Jul 19, 2017 at 11:50 AM, Ronald S. Bultje wrote: > Hi Wan-Teh, > > On Wed, Jul 19, 2017 at 2:31 PM, Wan-Teh Chang > wrote: > >> In libavcodec/h264_direct.c, there is already an >> await_reference_mb_row() call before the read of >> sl->ref_list[1][0].parent->mb_type[mb_xy] at

Re: [FFmpeg-devel] tsan warning about a data race in libavcodec/h264_direct.c

2017-07-19 Thread Ronald S. Bultje
Hi Wan-Teh, On Wed, Jul 19, 2017 at 2:31 PM, Wan-Teh Chang wrote: > Hi Ronald, > > Thank you for the reply. > > On Wed, Jul 19, 2017 at 8:56 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Jul 19, 2017 at 12:26 AM, Wan-Teh Chang < > > wtc-at-google@ffmpeg.org> wrote: > > > >> WARNING:

Re: [FFmpeg-devel] tsan warning about a data race in libavcodec/h264_direct.c

2017-07-19 Thread Wan-Teh Chang
Hi Ronald, Thank you for the reply. On Wed, Jul 19, 2017 at 8:56 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Jul 19, 2017 at 12:26 AM, Wan-Teh Chang < > wtc-at-google@ffmpeg.org> wrote: > >> WARNING: ThreadSanitizer: data race (pid=116081) >> Read of size 4 at 0x7b720118 by thread T3

Re: [FFmpeg-devel] tsan warning about a data race in libavcodec/h264_direct.c

2017-07-19 Thread Ronald S. Bultje
Hi, On Wed, Jul 19, 2017 at 12:26 AM, Wan-Teh Chang < wtc-at-google@ffmpeg.org> wrote: > WARNING: ThreadSanitizer: data race (pid=116081) > Read of size 4 at 0x7b720118 by thread T3 (mutexes: write M2239): > #0 pred_temp_direct_motion ffmpeg/libavcodec/h264_direct.c:505:9 > (ffmpeg+

[FFmpeg-devel] tsan warning about a data race in libavcodec/h264_direct.c

2017-07-18 Thread Wan-Teh Chang
Hi, I'd like to report a tsan warning about a data race in libavcodec/h264_direct.c. 1. Steps to reproduce: ./configure --samples=~/fate-suite/ --toolchain=clang-tsan --disable-stripping make fate-h264 THREADS=4 2. Here is an excerpt of the tsan warning in tests/data/fate/h264-conformance-frex