Re: [FFmpeg-devel] setting vps/sps/pps id via hevc_metadata

2020-01-08 Thread Andreas Rheinhardt
On Wed, Jan 8, 2020 at 9:12 AM Eran Gonen wrote: > Would it make more sense if I'll change it to advance sps id? offering no > risk for multiple ps > > That would be safe (if you reduce the id modulo the number of allowed values afterwards). - Andreas PS: Avoid top-posting on this list. ___

Re: [FFmpeg-devel] setting vps/sps/pps id via hevc_metadata

2020-01-08 Thread Eran Gonen
Would it make more sense if I'll change it to advance sps id? offering no risk for multiple ps On Tue, Jan 7, 2020 at 3:54 PM Eran Gonen wrote: > Hi, > This filter allows editing hevc headers and change metadata. Most > modifications doesn't make sense for all multiple PS streams (even if they >

Re: [FFmpeg-devel] setting vps/sps/pps id via hevc_metadata

2020-01-07 Thread Eran Gonen
Hi, This filter allows editing hevc headers and change metadata. Most modifications doesn't make sense for all multiple PS streams (even if they are decodable): same crop for different resolutions, the same tick_rate for different FR. Changing the PS id allows a wide range of stream compositions an

Re: [FFmpeg-devel] setting vps/sps/pps id via hevc_metadata

2020-01-06 Thread Mark Thompson
On 06/01/2020 19:24, Eran Gonen wrote:> On Mon, Jan 6, 2020 at 9:05 PM Andreas Rheinhardt < > andreas.rheinha...@gmail.com> wrote: > >> On Mon, Jan 6, 2020 at 7:54 PM Eran Gonen >> wrote: >> >>> Hi, >>> >>> The attached patch allows setting vps/sps/pps id >>> >>> Usage: >>> /ffmpeg -i source -c:

Re: [FFmpeg-devel] setting vps/sps/pps id via hevc_metadata

2020-01-06 Thread Eran Gonen
Thanks Andreas. I also thought about this point. I guess the same goes to the rest of parameters in hevc_metadata. They all affect all sets in the file. Maybe that's the intention of the user for such files. On Mon, Jan 6, 2020 at 9:05 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote:

Re: [FFmpeg-devel] setting vps/sps/pps id via hevc_metadata

2020-01-06 Thread Andreas Rheinhardt
On Mon, Jan 6, 2020 at 7:54 PM Eran Gonen wrote: > Hi, > > The attached patch allows setting vps/sps/pps id > > Usage: > /ffmpeg -i source -c:v libx265 -bsf:v > hevc_metadata=sps_id=8:pps_id=12:vps_id=3 output > > There is a problem with this: Input files with parameter sets of the same kind with

[FFmpeg-devel] setting vps/sps/pps id via hevc_metadata

2020-01-06 Thread Eran Gonen
Hi, The attached patch allows setting vps/sps/pps id Usage: /ffmpeg -i source -c:v libx265 -bsf:v hevc_metadata=sps_id=8:pps_id=12:vps_id=3 output Best, Eran Gonen 0001-Add-vps-sps-pps-id-set-to-hevc_metadata-bsf.patch Description: Binary data 0001-Add-vps-sps-pps-id-set-to-hevc_metadata-bsf