On 02/01/15 6:34 PM, Michael Niedermayer wrote:
> On Fri, Jan 02, 2015 at 05:13:33PM +0100, Giorgio Vazzana wrote:
>> Hello,
>>
>> 2015-01-02 15:17 GMT+01:00 Michael Niedermayer :
>>> i assume giorgio is ok with the patch as he previously said "rest LGTM"
>>> so applied
>>
>> thank you Supraja for
On Fri, Jan 02, 2015 at 05:13:33PM +0100, Giorgio Vazzana wrote:
> Hello,
>
> 2015-01-02 15:17 GMT+01:00 Michael Niedermayer :
> > i assume giorgio is ok with the patch as he previously said "rest LGTM"
> > so applied
>
> thank you Supraja for the good work and thanks Michael for applying the pat
Hello,
2015-01-02 15:17 GMT+01:00 Michael Niedermayer :
> i assume giorgio is ok with the patch as he previously said "rest LGTM"
> so applied
thank you Supraja for the good work and thanks Michael for applying the patch.
I spotted only minor things, attached some patches from most important
to
On Fri, Jan 02, 2015 at 02:03:05PM +0530, supraja reddy wrote:
> Hello,
>
> I have modified the LR128 function slightly to make it more compact.
>
> Thanks,
> Supraja
>
> On Wed, Dec 31, 2014 at 9:53 PM, supraja reddy
> wrote:
>
> > Hello,
> >
> > I have made the following changes.
> >
> > >
Hello,
I have modified the LR128 function slightly to make it more compact.
Thanks,
Supraja
On Wed, Dec 31, 2014 at 9:53 PM, supraja reddy
wrote:
> Hello,
>
> I have made the following changes.
>
> > create mode 100644 libavutil/camellia.h
>>
>> Missing changelog entry.
>>
> I have updated th
Hello,
I have made the following changes.
> create mode 100644 libavutil/camellia.h
>
> Missing changelog entry.
>
I have updated the changelog. I had earlier ignored this because i also had
to update changelog for cast128 cbc mode and wanted to do both together.
>
> We don't need it in this ca
Hello,
2014-12-29 17:40 GMT+01:00 supraja reddy :
> Hello,
>
> I have updated the patch. Please let me know if any further changes are
> required.
we're almost there, a few things to fix before we can commit (for each
one please indicate in your reply if you have fixed/changed it or not.
This wil
Hello,
I have updated the patch. Please let me know if any further changes are
required.
Thanks,
Supraja
On Sat, Dec 27, 2014 at 11:04 PM, Giorgio Vazzana
wrote:
> 2014-12-26 20:01 GMT+01:00 Michael Niedermayer :
> > [...]
> >
> >> +static uint64_t F(uint64_t F_IN, uint64_t KE)
> >> +{
> >> +
2014-12-26 20:01 GMT+01:00 Michael Niedermayer :
> [...]
>
>> +static uint64_t F(uint64_t F_IN, uint64_t KE)
>> +{
>> +uint32_t Zl, Zr;
>
>> +Zl = (F_IN >> 32) ^ (KE >> 32);
>> +Zr = (F_IN & MASK32) ^ (KE & MASK32);
>
> KE ^= F_IN;
> Zl = KE >> 32;
> Zr = KE & MASK32;
>
>
>> +Zl = (
Hi,
2014-12-24 23:41 GMT+01:00 supraja reddy :
> Hello,
>
> Thank you for your reviews. I have attached the updated patch .
>
> You are using a single array K for all the keys, without distinguishing
>> between
>> kw, k and ke as in the rfc. This makes code harder to read/maintain with no
>> real
On Fri, Dec 26, 2014 at 08:48:27PM +0530, supraja reddy wrote:
> Hello,
>
> I made a small change in the decrypt function which I should have done so
> earlier.
> Please let me know of the further changes/fixes.
>
> Thanks,
>
> Supraja
>
[...]
> +static uint64_t F(uint64_t F_IN, uint64_t KE)
Hello,
I made a small change in the decrypt function which I should have done so
earlier.
Please let me know of the further changes/fixes.
Thanks,
Supraja
On Thu, Dec 25, 2014 at 4:11 AM, supraja reddy
wrote:
> Hello,
>
> Thank you for your reviews. I have attached the updated patch .
>
> You
Hello,
Thank you for your reviews. I have attached the updated patch .
You are using a single array K for all the keys, without distinguishing
> between
> kw, k and ke as in the rfc. This makes code harder to read/maintain with no
> real gain I guess. Any reason why you made this decision?
>
I h
Hello Supraja,
2014-12-23 18:38 GMT+01:00 supraja reddy :
> I have attached the patch to the basic implementation of camellia block
> cipher. Please let me know if there are any bugs to be fixed or if any
> further optimization needed.
thanks for the patch and thank you Michael for the first revi
On Tue, Dec 23, 2014 at 11:08:09PM +0530, supraja reddy wrote:
> Hello ,
>
> I have attached the patch to the basic implementation of camellia block
> cipher. Please let me know if there are any bugs to be fixed or if any
> further optimization needed.
[...]
> +static void LROT(uint64_t *K, int x
Hello ,
I have attached the patch to the basic implementation of camellia block
cipher. Please let me know if there are any bugs to be fixed or if any
further optimization needed.
Thanks ,
Supraja
From 4ace69c4cc76f04e0e795e67290e979925df600c Mon Sep 17 00:00:00 2001
From: Supraja Meedinti
Date
16 matches
Mail list logo
