Re: [FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-11-04 Thread Kieran Kunhya
On Sat, 4 Nov 2017 at 18:28 Michael Niedermayer wrote: > > The UUID can be corrupt as well. > > We shouldn't be printing random data from the bitstream to the users > > terminal. > > i agree > Ok, I will push unless someone objects. Kieran ___ ffmpeg-

Re: [FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-11-04 Thread Michael Niedermayer
On Sat, Nov 04, 2017 at 06:23:12PM +, Kieran Kunhya wrote: > On Sat, 6 May 2017 at 17:51 James Almer wrote: > > > The proper change here would be to look at the uuid and print only those > > known to store printable strings, and of course after making sure they > > are in fact printable. > >

Re: [FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-11-04 Thread Kieran Kunhya
On Sat, 6 May 2017 at 17:51 James Almer wrote: > The proper change here would be to look at the uuid and print only those > known to store printable strings, and of course after making sure they > are in fact printable. > As of now, that means x264's uuid only. > The UUID can be corrupt as well.

Re: [FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-05-06 Thread James Almer
On 5/6/2017 1:37 PM, Michael Niedermayer wrote: > On Fri, May 05, 2017 at 09:30:54PM +, Kieran Kunhya wrote: >> From d43c0366d4ba128772dc7909152f4e9635f269cb Mon Sep 17 00:00:00 2001 >> From: Kieran Kunhya >> Date: Fri, 5 May 2017 14:29:59 -0700 >> Subject: [PATCH] libavcodec/h264_sei: Don't l

Re: [FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-05-06 Thread Michael Niedermayer
On Fri, May 05, 2017 at 09:30:54PM +, Kieran Kunhya wrote: > From d43c0366d4ba128772dc7909152f4e9635f269cb Mon Sep 17 00:00:00 2001 > From: Kieran Kunhya > Date: Fri, 5 May 2017 14:29:59 -0700 > Subject: [PATCH] libavcodec/h264_sei: Don't log random user data. This > prevents terminal junk. >

[FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-05-05 Thread Kieran Kunhya
From d43c0366d4ba128772dc7909152f4e9635f269cb Mon Sep 17 00:00:00 2001 From: Kieran Kunhya Date: Fri, 5 May 2017 14:29:59 -0700 Subject: [PATCH] libavcodec/h264_sei: Don't log random user data. This prevents terminal junk. --- libavcodec/h264_sei.c | 3 --- 1 file changed, 3 deletions(-) diff