Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-16 Thread Carl Eugen Hoyos
2017-11-13 6:41 GMT+01:00 Umair Khan : > Hi, > > On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >> 2017-11-12 20:30 GMT+01:00 Umair Khan : >>> Hi, >>> >>> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos >>> wrote: 2017-11-12 20:05 GMT+01:00 Umair Khan : > The attached

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-16 Thread Thilo Borgmann
Am 16.11.17 um 19:24 schrieb Thilo Borgmann: > Am 14.11.17 um 08:23 schrieb Umair Khan: >> Hi, >> >> On Tue, Nov 14, 2017 at 4:05 AM, Carl Eugen Hoyos wrote: >>> 2017-11-13 6:41 GMT+01:00 Umair Khan : Hi, On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: > 2017-11-

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-16 Thread Thilo Borgmann
Am 14.11.17 um 08:23 schrieb Umair Khan: > Hi, > > On Tue, Nov 14, 2017 at 4:05 AM, Carl Eugen Hoyos wrote: >> 2017-11-13 6:41 GMT+01:00 Umair Khan : >>> Hi, >>> >>> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos >>> wrote: 2017-11-12 20:30 GMT+01:00 Umair Khan : > Hi, > > O

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-15 Thread Carl Eugen Hoyos
2017-11-15 8:54 GMT+01:00 Umair Khan : > I'm now moving to the ALS encoder tasks before we start with the next GSoC. Great! Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-14 Thread Umair Khan
Hi, On Wed, Nov 15, 2017 at 4:20 AM, Carl Eugen Hoyos wrote: > 2017-11-14 23:48 GMT+01:00 Carl Eugen Hoyos : >> 2017-11-13 21:07 GMT+01:00 Thilo Borgmann : >>> Am 13.11.17 um 21:06 schrieb Thilo Borgmann: Am 13.11.17 um 20:02 schrieb Umair Khan: > Hi, > > On Mon, Nov 13, 2017 at

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-14 Thread Carl Eugen Hoyos
2017-11-14 23:48 GMT+01:00 Carl Eugen Hoyos : > 2017-11-13 21:07 GMT+01:00 Thilo Borgmann : >> Am 13.11.17 um 21:06 schrieb Thilo Borgmann: >>> Am 13.11.17 um 20:02 schrieb Umair Khan: Hi, On Mon, Nov 13, 2017 at 11:06 PM, Thilo Borgmann wrote: > Hi, > >> On Mon, N

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-14 Thread Carl Eugen Hoyos
2017-11-13 21:07 GMT+01:00 Thilo Borgmann : > Am 13.11.17 um 21:06 schrieb Thilo Borgmann: >> Am 13.11.17 um 20:02 schrieb Umair Khan: >>> Hi, >>> >>> On Mon, Nov 13, 2017 at 11:06 PM, Thilo Borgmann >>> wrote: Hi, > On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos > wrote: >

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-13 Thread Umair Khan
Hi, On Tue, Nov 14, 2017 at 4:05 AM, Carl Eugen Hoyos wrote: > 2017-11-13 6:41 GMT+01:00 Umair Khan : >> Hi, >> >> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >>> 2017-11-12 20:30 GMT+01:00 Umair Khan : Hi, On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos wro

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-13 Thread Carl Eugen Hoyos
2017-11-13 6:41 GMT+01:00 Umair Khan : > Hi, > > On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >> 2017-11-12 20:30 GMT+01:00 Umair Khan : >>> Hi, >>> >>> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos >>> wrote: 2017-11-12 20:05 GMT+01:00 Umair Khan : > The attached

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-13 Thread Thilo Borgmann
Am 13.11.17 um 21:06 schrieb Thilo Borgmann: > Am 13.11.17 um 20:02 schrieb Umair Khan: >> Hi, >> >> On Mon, Nov 13, 2017 at 11:06 PM, Thilo Borgmann >> wrote: >>> Hi, >>> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: > 2017-11-12 20:30 GMT+01:00 Umair Khan : >> Hi,

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-13 Thread Thilo Borgmann
Am 13.11.17 um 20:02 schrieb Umair Khan: > Hi, > > On Mon, Nov 13, 2017 at 11:06 PM, Thilo Borgmann > wrote: >> Hi, >> >>> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos >>> wrote: 2017-11-12 20:30 GMT+01:00 Umair Khan : > Hi, > > On Mon, Nov 13, 2017 at 12:45 AM, Carl Euge

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-13 Thread Umair Khan
Hi, On Mon, Nov 13, 2017 at 11:06 PM, Thilo Borgmann wrote: > Hi, > >> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >>> 2017-11-12 20:30 GMT+01:00 Umair Khan : Hi, On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos wrote: > 2017-11-12 20:05 GMT+01:00 Umair K

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-13 Thread Thilo Borgmann
Hi, > On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >> 2017-11-12 20:30 GMT+01:00 Umair Khan : >>> Hi, >>> >>> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos >>> wrote: 2017-11-12 20:05 GMT+01:00 Umair Khan : > The attached patch fixes the address sanitizer issue. >

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-12 Thread Umair Khan
Hi, On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: > 2017-11-12 20:30 GMT+01:00 Umair Khan : >> Hi, >> >> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos >> wrote: >>> 2017-11-12 20:05 GMT+01:00 Umair Khan : >>> The attached patch fixes the address sanitizer issue. >>> >>> Bre

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-12 Thread Carl Eugen Hoyos
2017-11-12 20:30 GMT+01:00 Umair Khan : > Hi, > > On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos wrote: >> 2017-11-12 20:05 GMT+01:00 Umair Khan : >> >>> The attached patch fixes the address sanitizer issue. >> >> Breaks compilation here, how did you test? >> >> libavcodec/alsdec.c: In functio

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-12 Thread Umair Khan
Hi, On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos wrote: > 2017-11-12 20:05 GMT+01:00 Umair Khan : > >> The attached patch fixes the address sanitizer issue. > > Breaks compilation here, how did you test? > > libavcodec/alsdec.c: In function ‘decode_var_block_data’: > libavcodec/alsdec.c:938

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-12 Thread Carl Eugen Hoyos
2017-11-12 20:05 GMT+01:00 Umair Khan : > The attached patch fixes the address sanitizer issue. Breaks compilation here, how did you test? libavcodec/alsdec.c: In function ‘decode_var_block_data’: libavcodec/alsdec.c:938:7: error: expected ‘}’ before ‘else’ Carl Eugen _

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-12 Thread Umair Khan
Hi, On Sat, Nov 4, 2017 at 3:11 AM, Thilo Borgmann wrote: > Am 03.11.17 um 21:13 schrieb Paul B Mahol: >> On 11/3/17, Thilo Borgmann wrote: >>> Am 02.11.17 um 21:32 schrieb Umair Khan: Hi, On Fri, Oct 20, 2017 at 1:44 AM, Ronald S. Bultje wrote: > > Hi, > > O

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-03 Thread Thilo Borgmann
Am 03.11.17 um 21:13 schrieb Paul B Mahol: > On 11/3/17, Thilo Borgmann wrote: >> Am 02.11.17 um 21:32 schrieb Umair Khan: >>> Hi, >>> >>> On Fri, Oct 20, 2017 at 1:44 AM, Ronald S. Bultje >>> wrote: Hi, On Thu, Oct 19, 2017 at 4:03 PM, Umair Khan wrote: > I tried de

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-03 Thread Paul B Mahol
On 11/3/17, Thilo Borgmann wrote: > Am 02.11.17 um 21:32 schrieb Umair Khan: >> Hi, >> >> On Fri, Oct 20, 2017 at 1:44 AM, Ronald S. Bultje >> wrote: >>> >>> Hi, >>> >>> On Thu, Oct 19, 2017 at 4:03 PM, Umair Khan wrote: >>> I tried decoding the file in both the cases and I don't see any >>

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-03 Thread Thilo Borgmann
Am 02.11.17 um 21:32 schrieb Umair Khan: > Hi, > > On Fri, Oct 20, 2017 at 1:44 AM, Ronald S. Bultje wrote: >> >> Hi, >> >> On Thu, Oct 19, 2017 at 4:03 PM, Umair Khan wrote: >> >>> I tried decoding the file in both the cases and I don't see any >>> address related error in the console while dec

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-02 Thread Umair Khan
Hi, On Fri, Oct 20, 2017 at 1:44 AM, Ronald S. Bultje wrote: > > Hi, > > On Thu, Oct 19, 2017 at 4:03 PM, Umair Khan wrote: > > > I tried decoding the file in both the cases and I don't see any > > address related error in the console while decoding. Following is the > > output after I apply the

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-19 Thread Ronald S. Bultje
Hi, On Thu, Oct 19, 2017 at 4:03 PM, Umair Khan wrote: > I tried decoding the file in both the cases and I don't see any > address related error in the console while decoding. Following is the > output after I apply the patch :- > [..] > Is there something which I'm missing? > You need to run

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-19 Thread Umair Khan
Hi Ronald, On Sun, Oct 15, 2017 at 12:21 AM, Ronald S. Bultje wrote: > Hi Umair, > > On Sat, Oct 14, 2017 at 1:43 PM, Umair Khan wrote: > >> On Sat, Oct 14, 2017 at 8:02 PM, Ronald S. Bultje >> wrote: >> > Hi Umair, >> > >> > On Sat, Oct 14, 2017 at 9:59 AM, Umair Khan wrote: >> > >> >> I test

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-14 Thread Ronald S. Bultje
Hi Umair, On Sat, Oct 14, 2017 at 1:43 PM, Umair Khan wrote: > On Sat, Oct 14, 2017 at 8:02 PM, Ronald S. Bultje > wrote: > > Hi Umair, > > > > On Sat, Oct 14, 2017 at 9:59 AM, Umair Khan wrote: > > > >> I tested the file which Michael sent. The thing is that I'm getting > >> error in decoding

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-14 Thread Umair Khan
On Sat, Oct 14, 2017 at 8:02 PM, Ronald S. Bultje wrote: > Hi Umair, > > On Sat, Oct 14, 2017 at 9:59 AM, Umair Khan wrote: > >> I tested the file which Michael sent. The thing is that I'm getting >> error in decoding that file in both the cases, with or without the >> patch. I will begin debuggi

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-14 Thread Ronald S. Bultje
Hi Umair, On Sat, Oct 14, 2017 at 9:59 AM, Umair Khan wrote: > I tested the file which Michael sent. The thing is that I'm getting > error in decoding that file in both the cases, with or without the > patch. I will begin debugging this issue, however I think the file > which Michael sent has go

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-14 Thread Umair Khan
On Sat, Oct 14, 2017 at 7:29 PM, Umair Khan wrote: > Hi, > > On Sat, Sep 23, 2017 at 8:45 PM, Michael Niedermayer > wrote: >> >> On Fri, Sep 22, 2017 at 01:54:27PM +0530, Umair Khan wrote: >> > On Thu, Sep 21, 2017 at 6:30 PM, Paul B Mahol wrote: >> > > On 9/21/17, Umair Khan wrote: >> > >> Hi

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-14 Thread Umair Khan
Hi, On Sat, Sep 23, 2017 at 8:45 PM, Michael Niedermayer wrote: > > On Fri, Sep 22, 2017 at 01:54:27PM +0530, Umair Khan wrote: > > On Thu, Sep 21, 2017 at 6:30 PM, Paul B Mahol wrote: > > > On 9/21/17, Umair Khan wrote: > > >> Hi Ronald, > > >> > > >> On Mon, Sep 11, 2017 at 10:27 PM, Ronald S

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-23 Thread Michael Niedermayer
On Fri, Sep 22, 2017 at 01:54:27PM +0530, Umair Khan wrote: > On Thu, Sep 21, 2017 at 6:30 PM, Paul B Mahol wrote: > > On 9/21/17, Umair Khan wrote: > >> Hi Ronald, > >> > >> On Mon, Sep 11, 2017 at 10:27 PM, Ronald S. Bultje > >> wrote: > >>> Hi Umair, > >>> > >>> On Mon, Sep 11, 2017 at 4:06 A

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-22 Thread Umair Khan
On Thu, Sep 21, 2017 at 6:30 PM, Paul B Mahol wrote: > On 9/21/17, Umair Khan wrote: >> Hi Ronald, >> >> On Mon, Sep 11, 2017 at 10:27 PM, Ronald S. Bultje >> wrote: >>> Hi Umair, >>> >>> On Mon, Sep 11, 2017 at 4:06 AM, Umair Khan wrote: >>> On Sun, Sep 10, 2017 at 10:30 PM, Paul B Mahol

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-21 Thread Paul B Mahol
On 9/21/17, Umair Khan wrote: > Hi Ronald, > > On Mon, Sep 11, 2017 at 10:27 PM, Ronald S. Bultje > wrote: >> Hi Umair, >> >> On Mon, Sep 11, 2017 at 4:06 AM, Umair Khan wrote: >> >>> On Sun, Sep 10, 2017 at 10:30 PM, Paul B Mahol wrote: >>> > On 9/10/17, Umair Khan wrote: >>> >> On Sun, Sep 1

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-21 Thread Umair Khan
Hi Ronald, On Mon, Sep 11, 2017 at 10:27 PM, Ronald S. Bultje wrote: > Hi Umair, > > On Mon, Sep 11, 2017 at 4:06 AM, Umair Khan wrote: > >> On Sun, Sep 10, 2017 at 10:30 PM, Paul B Mahol wrote: >> > On 9/10/17, Umair Khan wrote: >> >> On Sun, Sep 10, 2017 at 9:52 PM, Thilo Borgmann > > >> >>

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-11 Thread Ronald S. Bultje
Hi Umair, On Mon, Sep 11, 2017 at 4:06 AM, Umair Khan wrote: > On Sun, Sep 10, 2017 at 10:30 PM, Paul B Mahol wrote: > > On 9/10/17, Umair Khan wrote: > >> On Sun, Sep 10, 2017 at 9:52 PM, Thilo Borgmann > > >> wrote: > >>> > >>> Hi, > >>> > >>> > This patch fixes this bug - https://trac.ffmp

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-11 Thread Umair Khan
On Sun, Sep 10, 2017 at 10:30 PM, Paul B Mahol wrote: > On 9/10/17, Umair Khan wrote: >> On Sun, Sep 10, 2017 at 9:52 PM, Thilo Borgmann >> wrote: >>> >>> Hi, >>> >>> > This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297 >>> >>> this is yet another iteration of >>> >>> http://ffmpeg.

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-10 Thread Paul B Mahol
On 9/10/17, Umair Khan wrote: > On Sun, Sep 10, 2017 at 9:52 PM, Thilo Borgmann > wrote: >> >> Hi, >> >> > This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297 >> >> this is yet another iteration of >> >> http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/213005.html > > I see. I was k

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-10 Thread Umair Khan
On Sun, Sep 10, 2017 at 9:52 PM, Thilo Borgmann wrote: > > Hi, > > > This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297 > > this is yet another iteration of > > http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/213005.html I see. I was keepnig reference codec as the source of truth.

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-10 Thread Thilo Borgmann
Hi, > This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297 this is yet another iteration of http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/213005.html -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailma

[FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-10 Thread Umair Khan
Hi, This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297 I suggest removing the check because opt_order can be larger than block_length for the last frames. I checked this in reference codec as well. opt_order is larger than block_length for last 2 frames. Hence, I don't think there's