Re: [FFmpeg-devel] lavf: Add DICOM demuxer

2019-08-28 Thread Moritz Barsnick
On Wed, Aug 28, 2019 at 00:44:24 +0530, Shivam wrote: > > Again, here, I expect this to be a switch/case with one case only if it > > can be expanded later, i.e. de->ElementNumber has multiple meanings > > which aren't covered here. > This would be expanded in my next patch, so, i thought this may

Re: [FFmpeg-devel] lavf: Add DICOM demuxer

2019-08-27 Thread Shivam
On 8/27/19 2:05 AM, Moritz Barsnick wrote: On Sun, Aug 25, 2019 at 03:22:02 +0530, Shivam wrote: The patch contains DICOM demuxer. I have improved the code as suggested. Second part of my review: From: Shivam Goyal <1998.goyal.shi...@gmail.com> Date: Sun, 25 Aug 2019 02:57:35 +0530 Subject:

Re: [FFmpeg-devel] lavf: Add DICOM demuxer

2019-08-26 Thread Moritz Barsnick
On Sun, Aug 25, 2019 at 03:22:02 +0530, Shivam wrote: > The patch contains DICOM demuxer. I have improved the code as suggested. Second part of my review: > From: Shivam Goyal <1998.goyal.shi...@gmail.com> > Date: Sun, 25 Aug 2019 02:57:35 +0530 > Subject: [PATCH] lavf: Add DICOM demuxer > > ---

[FFmpeg-devel] lavf: Add DICOM demuxer

2019-08-24 Thread Shivam
The patch contains DICOM demuxer. I have improved the code as suggested. Please, push it as soon as possible, as i have to share the commit in GSoC final evaluation. if anything remain i would add it after that. Thank you, Shivam Goyal >From e76ce45b2f7c0e6ce9706cbcb62da147e56e3e61 Mon Sep 1