Re: [FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Carl Eugen Hoyos
Jon bae gmail.com> writes: > that means that the patch is at the moment not useful?! I believe it is very useful! To get it into the FFmpeg git repository, please: Split the patch in two (one patch per issue). Remove the tab. Fix the indentation. Do not change av_log() into fprintf(). Do not mo

Re: [FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Jon bae
Hello Carl, that means that the patch is at the moment not useful?! This code comes from the decklink sdk and there was also the FAILED() defined, I think. I have the code from here: http://ffmpeg.zeranoe.com/forum/viewtopic.php?f=10&t=1823&start=10#p7580 and there they say it works. When is ok fo

Re: [FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Carl Eugen Hoyos
Jon bae gmail.com> writes: > I hope is all right, I never did before a > git format-patch... You used git format-patch perfectly, thank you. Your patch introduces tabs, they cannot be committed to FFmpeg. You can find tabs with "tools/patcheck", a script that is part of the source. Please d

[FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Jon bae
Hello everybody, on the Zeranoe forum we find out that there is two bugs in the decklink_common.cpp file. I build I patch and want to send them now to you. I hope is all right, I never did before a git format-patch... Regards! Jonathan fix-device_list-and-COM-initialization-failed_in decklink_c