Linjie Fu (12021-08-05):
> Double confirmed locally, Yes, and the first commit has passed the
> patchwork too:
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210804170311.86426-1-fulin...@zju.edu.cn/
Thanks. I find very surprising that the second patch, which changes a
default too, does no
On Thu, Aug 5, 2021 at 11:22 PM Nicolas George wrote:
> Linjie Fu (12021-08-05):
> > Where is supposed to be the right placement?
>
> In the commit that makes the results change.
>
> Just do this: checkout the first commit, build, run FATE. Does it pass?
>
Double confirmed locally, Yes, and the
Linjie Fu (12021-08-05):
> Where is supposed to be the right placement?
In the commit that makes the results change.
Just do this: checkout the first commit, build, run FATE. Does it pass?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_
On Thu, Aug 5, 2021 at 10:54 PM Nicolas George wrote:
> Linjie Fu (12021-08-05):
> > This initials from your review comments to remove setting defaults in
> > ffmpeg (etc) and use the default flags in swscale,
> > and I didn't see objections at least till now. Did I misunderstand?
>
> I approved
Linjie Fu (12021-08-05):
> This initials from your review comments to remove setting defaults in
> ffmpeg (etc) and use the default flags in swscale,
> and I didn't see objections at least till now. Did I misunderstand?
I approved the general principle and the lavfi parts. I do not maintain
the ff
