Re: [FFmpeg-devel] ffmpeg patch for nonmonolithic increase dts error in subtitle

2018-06-22 Thread Michael Niedermayer
On Thu, Jun 21, 2018 at 09:11:56PM +0200, Michael Niedermayer wrote: > On Thu, Jun 21, 2018 at 02:27:29PM +0200, Carl Eugen Hoyos wrote: > > 2018-06-21 13:55 GMT+02:00, Moritz Barsnick : > > > On Thu, Jun 21, 2018 at 10:51:33 +0200, Carl Eugen Hoyos wrote: > > > > >> Who wrote the patch / where di

Re: [FFmpeg-devel] ffmpeg patch for nonmonolithic increase dts error in subtitle

2018-06-21 Thread Michael Niedermayer
On Thu, Jun 21, 2018 at 02:27:29PM +0200, Carl Eugen Hoyos wrote: > 2018-06-21 13:55 GMT+02:00, Moritz Barsnick : > > On Thu, Jun 21, 2018 at 10:51:33 +0200, Carl Eugen Hoyos wrote: > > >> Who wrote the patch / where did you find it? > > > > The ticket he mentioned was #4450, the patch is here: >

Re: [FFmpeg-devel] ffmpeg patch for nonmonolithic increase dts error in subtitle

2018-06-21 Thread Markus Kohm
Am Donnerstag, 21. Juni 2018, 17:36:02 CEST schrieb Carl Eugen Hoyos: > As in "copyright should be ignored by FFmpeg developers" or do > I misunderstand your comment? I do not understand the relation of copyright and my patch or any of my comments. So I cannot answer this question. If you have a

Re: [FFmpeg-devel] ffmpeg patch for nonmonolithic increase dts error in subtitle

2018-06-21 Thread Carl Eugen Hoyos
2018-06-21 16:20 GMT+02:00, Markus Kohm : > Am Donnerstag, 21. Juni 2018, 14:27:29 CEST schrieb Carl Eugen Hoyos: >> Patch attached (untested). > > As already mentioned in my first mail I've tested the patch and it works as > expected. > > Markus > > PS: Now, I know why others have warned me, that

Re: [FFmpeg-devel] ffmpeg patch for nonmonolithic increase dts error in subtitle

2018-06-21 Thread Markus Kohm
Am Donnerstag, 21. Juni 2018, 14:27:29 CEST schrieb Carl Eugen Hoyos: > Patch attached (untested). As already mentioned in my first mail I've tested the patch and it works as expected. Markus PS: Now, I know why others have warned me, that it could become very, very hard to send a feature requ

Re: [FFmpeg-devel] ffmpeg patch for nonmonolithic increase dts error in subtitle

2018-06-21 Thread Carl Eugen Hoyos
2018-06-21 13:55 GMT+02:00, Moritz Barsnick : > On Thu, Jun 21, 2018 at 10:51:33 +0200, Carl Eugen Hoyos wrote: >> Who wrote the patch / where did you find it? > > The ticket he mentioned was #4450, the patch is here: > https://trac.ffmpeg.org/ticket/4450#comment:6 Patch attached (untested). Tha

Re: [FFmpeg-devel] ffmpeg patch for nonmonolithic increase dts error in subtitle

2018-06-21 Thread Moritz Barsnick
On Thu, Jun 21, 2018 at 10:51:33 +0200, Carl Eugen Hoyos wrote: > This is exactly the same attachment as in your original mail... Not quite, it was a git diff this time, but obviously still not sufficient. > Who wrote the patch / where did you find it? The ticket he mentioned was #4450, the patc

Re: [FFmpeg-devel] ffmpeg patch for nonmonolithic increase dts error in subtitle

2018-06-21 Thread Carl Eugen Hoyos
2018-06-21 7:40 GMT+02:00, Markus Kohm : > Am Mittwoch, 20. Juni 2018, 22:54:34 CEST schrieb Michael Niedermayer: >> Please post a git compatible patch > > see attachtment This is exactly the same attachment as in your original mail... Who wrote the patch / where did you find it? Carl Eugen

Re: [FFmpeg-devel] ffmpeg patch for nonmonolithic increase dts error in subtitle

2018-06-20 Thread Markus Kohm
Am Mittwoch, 20. Juni 2018, 22:54:34 CEST schrieb Michael Niedermayer: > Please post a git compatible patch see attachtmentdiff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 6dfab64bc7..8d311a9ac8 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -772,7 +772,7 @@ static void write_packet

Re: [FFmpeg-devel] ffmpeg patch for nonmonolithic increase dts error in subtitle

2018-06-20 Thread Michael Niedermayer
On Wed, Jun 20, 2018 at 09:09:11AM +0200, Markus Kohm wrote: > Recoding videos with subtitles, I often have problems with subtitle streams, > because the dts starts again with 0 after some time (I think, it is at > jumping > from DVD layer 1 to 2, but I'm not sure). > > There is code in ffmpeg.

[FFmpeg-devel] ffmpeg patch for nonmonolithic increase dts error in subtitle

2018-06-20 Thread Markus Kohm
Recoding videos with subtitles, I often have problems with subtitle streams, because the dts starts again with 0 after some time (I think, it is at jumping from DVD layer 1 to 2, but I'm not sure). There is code in ffmpeg.c to handle such nonmonolithic dts errors in video and audio streams, but