Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-05-08 Thread Carl Eugen Hoyos
2018-05-08 11:45 GMT+02:00, Martin Vignali : >> >> > Sorry, i missread the code before writing the test, and >> > didn't see it use float for one step. >> > I will send a patch to remove these tests. >> >> Or just commit. >> >> > Tests removed. Thank you! Carl Eugen __

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-05-08 Thread Martin Vignali
> > > Sorry, i missread the code before writing the test, and > > didn't see it use float for one step. > > I will send a patch to remove these tests. > > Or just commit. > > Tests removed. Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org htt

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-04-24 Thread Carl Eugen Hoyos
2018-04-24 19:06 GMT+02:00, Martin Vignali : > Sorry, i missread the code before writing the test, and > didn't see it use float for one step. > I will send a patch to remove these tests. Or just commit. Thank you, Carl Eugen ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-04-24 Thread Martin Vignali
> > > > These tests are also broken, please fix or > > remove them: > > https://buildd.debian.org/status/fetch.php?pkg=ffmpeg&; > arch=i386&ver=7%3A4.0-1&stamp=152218&raw=0 > > ("Error 1") > > I've had a brief look at this error (and a similar error on s390x) and > it looks like a float roundin

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-04-24 Thread James Cowgill
On 23/04/18 10:11, Carl Eugen Hoyos wrote: > 2018-03-14 7:31 GMT+01:00, Martin Vignali : > >> In that case we can let the test using "none" >> compression (bypass the snappy part) > > These tests are also broken, please fix or > remove them: > https://buildd.debian.org/status/fetch.php?pkg=ffmpeg

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-04-23 Thread Carl Eugen Hoyos
2018-03-14 7:31 GMT+01:00, Martin Vignali : > In that case we can let the test using "none" > compression (bypass the snappy part) These tests are also broken, please fix or remove them: https://buildd.debian.org/status/fetch.php?pkg=ffmpeg&arch=i386&ver=7%3A4.0-1&stamp=152218&raw=0 ("Error 1

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-03-17 Thread Martin Vignali
> > In that case we can let the test using "none" compression (bypass the > snappy part) > and remove only snappy1 and snappy16 test > Like in patch in attach. > > Pushed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/list

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-03-13 Thread Martin Vignali
2018-03-14 1:48 GMT+01:00 James Almer : > On 3/13/2018 4:31 PM, Martin Vignali wrote: > > 2018-03-11 19:37 GMT+01:00 Martin Vignali : > > > >> > >> > >> 2017-11-26 18:25 GMT+01:00 Martin Vignali : > >> > >>> Hello, > >>> > >>> Patch in attach, add test for hap encoding (currently not cover) (patch

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-03-13 Thread James Almer
On 3/13/2018 4:31 PM, Martin Vignali wrote: > 2018-03-11 19:37 GMT+01:00 Martin Vignali : > >> >> >> 2017-11-26 18:25 GMT+01:00 Martin Vignali : >> >>> Hello, >>> >>> Patch in attach, add test for hap encoding (currently not cover) (patch >>> 002) >>> and move decoding tests to a separate file (pa

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-03-13 Thread Carl Eugen Hoyos
2018-03-14 0:26 GMT+01:00, Martin Vignali : >> >> >> >> Patch in attach, add test for hap encoding >> >> Why is this a good idea? > > The question, is maybe why is this a wrong idea ? We usually don't test external libraries, the main reason is probably that if they change behaviour, fate breaks (

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-03-13 Thread Martin Vignali
> >> > >> Patch in attach, add test for hap encoding > > Why is this a good idea? > The question, is maybe why is this a wrong idea ? > > Does the specification explain how encoding has to be done? > Not sure i understand, the spec explain that hap use DXT encoding and snappy, and explain the f

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-03-13 Thread Carl Eugen Hoyos
2018-03-11 19:37 GMT+01:00, Martin Vignali : > 2017-11-26 18:25 GMT+01:00 Martin Vignali : > >> Hello, >> >> Patch in attach, add test for hap encoding Why is this a good idea? Does the specification explain how encoding has to be done? This is very unusual, no? Even if so: Why are we testing an

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-03-13 Thread Martin Vignali
2018-03-11 19:37 GMT+01:00 Martin Vignali : > > > 2017-11-26 18:25 GMT+01:00 Martin Vignali : > >> Hello, >> >> Patch in attach, add test for hap encoding (currently not cover) (patch >> 002) >> and move decoding tests to a separate file (patch 001) >> >> decoding can be test with >> make fate-hap

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-03-11 Thread Martin Vignali
2017-11-26 18:25 GMT+01:00 Martin Vignali : > Hello, > > Patch in attach, add test for hap encoding (currently not cover) (patch > 002) > and move decoding tests to a separate file (patch 001) > > decoding can be test with > make fate-hap SAMPLES=fate-suite/ > > and encoding can be test with > mak

[FFmpeg-devel] fate/hap : add test for hap encoding

2017-11-26 Thread Martin Vignali
Hello, Patch in attach, add test for hap encoding (currently not cover) (patch 002) and move decoding tests to a separate file (patch 001) decoding can be test with make fate-hap SAMPLES=fate-suite/ and encoding can be test with make fate-hapenc SAMPLES=fate-suite/ Hap encoding need ffmpeg comp