Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-21 Thread Christopher Degawa
On Tue, Dec 21, 2021 at 1:40 AM Ridley Combs wrote: > Huh, TIL that the metal compiler doesn't exist without Xcode, but the > metal framework does! Wacky. Anyway, this patch oughtta fix that (does more > or less as you suggested); if this is all fine on your end, I'll go ahead > and split this up

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Christopher Degawa
On Mon, Dec 20, 2021 at 7:53 PM Aman Karmani wrote: > > > On Mon, Dec 20, 2021 at 5:48 PM Christopher Degawa > wrote: > >> >> >> On Mon, Dec 20, 2021 at 7:21 PM Aman Karmani wrote: >> >>> >>> >>> On Mon, Dec 20, 2021 at 5:03 PM Helmut K. C. Tessarek < >>> tessa...@evermeet.cx> wrote: >>> -

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2021-12-20 20:39, Ridley Combs wrote: > Try this (replacing all previous patches): > https://gist.github.com/2b1ea91330a748740d608680b0f8abd2 This worked splendidly. All good with this patch. If you want to test the binary on 10.9 or 10.10, her

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Aman Karmani
On Mon, Dec 20, 2021 at 5:48 PM Christopher Degawa wrote: > > > On Mon, Dec 20, 2021 at 7:21 PM Aman Karmani wrote: > >> >> >> On Mon, Dec 20, 2021 at 5:03 PM Helmut K. C. Tessarek < >> tessa...@evermeet.cx> wrote: >> >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA512 >>> >>> On 2021-12-20

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Christopher Degawa
On Mon, Dec 20, 2021 at 7:21 PM Aman Karmani wrote: > > > On Mon, Dec 20, 2021 at 5:03 PM Helmut K. C. Tessarek < > tessa...@evermeet.cx> wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 >> >> On 2021-12-20 19:11, Christopher Degawa wrote: >> > So I've exported "LIBRARY_PATH" to >>

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2021-12-20 20:20, Aman Karmani wrote: > Once we figure out why some computers are using the wrong metal binary, > then we can fix it and commit the fix to master as well. With the 2 patches from Ridley and your configure patch I run into the f

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Christopher Degawa
On Mon, Dec 20, 2021 at 7:29 PM Ridley Combs wrote: > The main thing that confuses me here is that this file does build for me > when I use the iOS version of the metal compiler (tbh I didn't even know > there was a difference between them). > > What Xcode and macOS version are you on? > system

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Christopher Degawa
On Mon, Dec 20, 2021 at 7:25 PM Aman Karmani wrote: > On Mon, Dec 20, 2021 at 5:19 PM Christopher Degawa > wrote: > > > On Mon, Dec 20, 2021 at 6:55 PM Aman Karmani wrote: > > > > > On Mon, Dec 20, 2021 at 4:52 PM Helmut K. C. Tessarek < > > > tessa...@evermeet.cx> > > > wrote: > > > > > > > --

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Aman Karmani
On Mon, Dec 20, 2021 at 5:19 PM Christopher Degawa wrote: > On Mon, Dec 20, 2021 at 6:55 PM Aman Karmani wrote: > > > On Mon, Dec 20, 2021 at 4:52 PM Helmut K. C. Tessarek < > > tessa...@evermeet.cx> > > wrote: > > > > > -BEGIN PGP SIGNED MESSAGE- > > > Hash: SHA512 > > > > > > > > > > >

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Aman Karmani
On Mon, Dec 20, 2021 at 5:03 PM Helmut K. C. Tessarek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 2021-12-20 19:11, Christopher Degawa wrote: > > So I've exported "LIBRARY_PATH" to > > I'm sorry to say, this is a workaround but hardly a solution. > No one said this is the s

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Christopher Degawa
On Mon, Dec 20, 2021 at 6:55 PM Aman Karmani wrote: > On Mon, Dec 20, 2021 at 4:52 PM Helmut K. C. Tessarek < > tessa...@evermeet.cx> > wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA512 > > > > > > > > On 2021-12-20 19:38, Aman Karmani wrote: > > > Could you share the output of `xc

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2021-12-20 19:11, Christopher Degawa wrote: > So I've exported "LIBRARY_PATH" to I'm sorry to say, this is a workaround but hardly a solution. Before these 2 commits all worked perfectly. Now it doesn't. Tweaking the build env is not a solution.

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Aman Karmani
On Mon, Dec 20, 2021 at 4:52 PM Helmut K. C. Tessarek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > > > On 2021-12-20 19:38, Aman Karmani wrote: > > Could you share the output of `xcrun metal -v` > > $ xcrun metal -v > Apple LLVM version 902.9 (metalfe-902.9.61) > Target: air64-a

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2021-12-20 19:50, Aman Karmani wrote: > Somehow yours is defaulting to the iOS binary. Do you have some > environment variable set that could be causing this? Even though this question was addressed to Christopher, my output also shows ios. And I

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2021-12-20 19:38, Aman Karmani wrote: > Could you share the output of `xcrun metal -v` $ xcrun metal -v Apple LLVM version 902.9 (metalfe-902.9.61) Target: air64-apple-darwin18.7.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Conte

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Aman Karmani
On Mon, Dec 20, 2021 at 4:43 PM Christopher Degawa wrote: > On Mon, Dec 20, 2021 at 6:39 PM Aman Karmani wrote: > > > > > Could you share the output of `xcrun metal -v` > > > > > xcrun metal -v > Apple LLVM version 31001.43 (metalfe-31001.43) > Target: air64-apple-darwin19.6.0 > Thread model: po

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Christopher Degawa
On Mon, Dec 20, 2021 at 6:39 PM Aman Karmani wrote: > > Could you share the output of `xcrun metal -v` > > xcrun metal -v Apple LLVM version 31001.43 (metalfe-31001.43) Target: air64-apple-darwin19.6.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDe

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Aman Karmani
On Mon, Dec 20, 2021 at 4:12 PM Christopher Degawa wrote: > On Mon, Dec 20, 2021 at 3:31 PM Helmut K. C. Tessarek < > tessa...@evermeet.cx> > wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA512 > > > > Hello, > > > > The following 2 commits break the build with a deployment target of

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2021-12-20 19:06, Ridley Combs wrote: > Try with this as well: > https://gist.github.com/499380d8ea03a86fc89eb48803ff7b2e Getting closer... CC libavfilter/generate_wave_table.o CC libavfilter/graphdump.o CC libavfilter/graphparser

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Christopher Degawa
On Mon, Dec 20, 2021 at 3:31 PM Helmut K. C. Tessarek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hello, > > The following 2 commits break the build with a deployment target of 10.9 on > macOS. > > I agree that 10.9 is quite old, but the rest of the code worked perfectly > fine

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Thanks for the rwply. On 2021-12-20 18:25, Ridley Combs wrote: > Could you try with this patch and let me know if it works for you then? > https://gist.github.com/7362df8a689c41b9174ac50fdeda3e43 I've applied your patch and get the following now:

[FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

2021-12-20 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello, The following 2 commits break the build with a deployment target of 10.9 on macOS. I agree that 10.9 is quite old, but the rest of the code worked perfectly fine, so were those 2 commits really necessary? * 4ac869ca2a | 2021-12-18 11:57:31