Re: [FFmpeg-devel] bad arguments to init_put_bits

2015-02-26 Thread Michael Niedermayer
On Thu, Feb 26, 2015 at 12:10:49PM -0800, Dyami Caliri wrote: > Do you want sample code that generates the crash? > > For "the code shouldn't really crash even without the patch," are you > saying that the code, as it's written, doesn't look it would crash? > Or are you saying that we need to chan

Re: [FFmpeg-devel] bad arguments to init_put_bits

2015-02-26 Thread Dyami Caliri
Do you want sample code that generates the crash? For "the code shouldn't really crash even without the patch," are you saying that the code, as it's written, doesn't look it would crash? Or are you saying that we need to change the code to make sure it doesn't crash, even without the patch? Here

Re: [FFmpeg-devel] bad arguments to init_put_bits

2015-02-26 Thread Michael Niedermayer
Hi On Thu, Feb 26, 2015 at 10:42:06AM -0800, Dyami Caliri wrote: > The init_put_bits() function (in libavcodec/put_bits.h) takes a buffer and > a buffer size (in bytes). Several of the encoders are passing the buffer > size in bits, by multiplying the buffer size by 8. This is incorrect. > > We

[FFmpeg-devel] bad arguments to init_put_bits

2015-02-26 Thread Dyami Caliri
The init_put_bits() function (in libavcodec/put_bits.h) takes a buffer and a buffer size (in bytes). Several of the encoders are passing the buffer size in bits, by multiplying the buffer size by 8. This is incorrect. We saw this problem when encoding a ProRes (Anatoliy) file at size 4096x4096. De