Re: [FFmpeg-devel] avformat/hls.c: Fix memory leak

2018-12-24 Thread Liu Steven
> 在 2018年12月24日,下午5:28,Valery Kot 写道: > > On Sat, Dec 22, 2018 at 6:33 PM Derek Buitenhuis > wrote: >> Can you add to the commit message to explain what exactly is >> changed and why? 'Fix leak' isn't very useful. > > Submitted a patch > (http://ffmpeg.org/pipermail/ffmpeg-devel/2018-December

Re: [FFmpeg-devel] avformat/hls.c: Fix memory leak

2018-12-24 Thread Valery Kot
On Sat, Dec 22, 2018 at 6:33 PM Derek Buitenhuis wrote: > Can you add to the commit message to explain what exactly is > changed and why? 'Fix leak' isn't very useful. Submitted a patch (http://ffmpeg.org/pipermail/ffmpeg-devel/2018-December/238093.html) with updated commit message, Or is there a

Re: [FFmpeg-devel] avformat/hls.c: Fix memory leak

2018-12-22 Thread Steven Liu
Valery Kot 于2018年12月22日周六 下午10:54写道: > > Ping... > Any maintainer willing to review/push straightforward one-liner patch? > > > Thus 59MB leak in an hour! And keeps growing... Testing. will response after one or two days, you can attention the comment by Derek, Thanks Valery Steven > > __

Re: [FFmpeg-devel] avformat/hls.c: Fix memory leak

2018-12-22 Thread Derek Buitenhuis
On 22/12/2018 14:54, Valery Kot wrote: > Ping... > Any maintainer willing to review/push straightforward one-liner patch? > >> Thus 59MB leak in an hour! And keeps growing... Can you add to the commit message to explain what exactly is changed and why? 'Fix leak' isn't very useful. Cheers, - Der

Re: [FFmpeg-devel] avformat/hls.c: Fix memory leak

2018-12-22 Thread Valery Kot
Ping... Any maintainer willing to review/push straightforward one-liner patch? > Thus 59MB leak in an hour! And keeps growing... ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] avformat/hls.c: Fix memory leak

2018-12-17 Thread Valery Kot
I just verified that patch is working. Build FFmpeg master with and without patch, run HLS live stream from Youtube (extracted by youtube_dl for Euronews live). ffmpeg -i https://manifest.googlevideo.com/api/manifest/hls_playlist/id/V2E-jOUVsd4.1/itag/95/source/yt_live_broadcast/requiressl/yes/ra

[FFmpeg-devel] avformat/hls.c: Fix memory leak

2018-12-14 Thread Valery Kot
Patch for https://trac.ffmpeg.org/ticket/7610 hls.c:933 free_segment_dynarray(prev_segments, prev_n_segments); cleans all elements of prev_segments, but does not frees prev_segments array itself. As a result, process slowly leaks memory every time it updates playlist. Added call to av_freep(&pre