Re: [FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-06 Thread wm4
On Sat, 6 Jan 2018 08:46:26 + "LongChair ." wrote: > Here are two updated patches. > > I have added the current version check to 1.3.7 and removed the header > check for control operation. Pushed the 2 patches. ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-06 Thread LongChair .
Here are two updated patches. I have added the current version check to 1.3.7 and removed the header check for control operation. On 05/01/2018 20:51, LongChair . wrote: > Yes this was bound to very old versions afaik. > > Mpp repo was squashed and we didn't have any version requirement > > Cur

Re: [FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-05 Thread LongChair .
Yes this was bound to very old versions afaik. Mpp repo was squashed and we didn't have any version requirement Current version is 1.3.7, if i trust my repo fork, previous version was 1.0.0, so we could add that as a requirement. On 05/01/2018 20:30, wm4 wrote: > On Fri, 5 Jan 2018 19:22:00 +0

Re: [FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-05 Thread wm4
On Fri, 5 Jan 2018 19:22:00 + "LongChair ." wrote: > Yes the newly used  control operation seems to have always been there > anyways, so there shouldn't be much compatibility issues. I mean the second patch removes a workaround for some old misbehavior, right? So it should probably be made

Re: [FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-05 Thread LongChair .
Yes the newly used  control operation seems to have always been there anyways, so there shouldn't be much compatibility issues. On 05/01/2018 20:19, wm4 wrote: > On Fri, 5 Jan 2018 19:02:25 + > "LongChair ." wrote: > >> Hi, >> >> Here are two patches that should : >> >> - fix https://trac.f

Re: [FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-05 Thread wm4
On Fri, 5 Jan 2018 19:02:25 + "LongChair ." wrote: > Hi, > > Here are two patches that should : > > - fix https://trac.ffmpeg.org/ticket/6834. > > - remove code that looked a bit hackish and which is not necessary anymore. > > The first patch is required as mpp removed some control operat

[FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-05 Thread LongChair .
Hi, Here are two patches that should : - fix https://trac.ffmpeg.org/ticket/6834. - remove code that looked a bit hackish and which is not necessary anymore. The first patch is required as mpp removed some control operation from the API, breaking the build. The second one is related to mpp fi