Re: [FFmpeg-devel] Segfault calling av_interleaved_write_frame

2020-01-20 Thread Jonathan Noble
On Sun, 19 Jan 2020 at 22:54, Nicolas George wrote: > Jonathan Noble (12020-01-19): > > I'd gathered that, but rather than bombing out shouldn't there be a > AVERROR > > returned or something else to notify the user of their error, like so > many > > other non-optional checks in ffmpeg? > > No. A

Re: [FFmpeg-devel] Segfault calling av_interleaved_write_frame

2020-01-19 Thread Nicolas George
Jonathan Noble (12020-01-19): > I'd gathered that, but rather than bombing out shouldn't there be a AVERROR > returned or something else to notify the user of their error, like so many > other non-optional checks in ffmpeg? No. AVERROR codes are not for errors that can be detected statically; thes

Re: [FFmpeg-devel] Segfault calling av_interleaved_write_frame

2020-01-19 Thread Jonathan Noble
On Sun, 19 Jan 2020 at 11:52, Nicolas George wrote: > Jonathan Noble (12020-01-19): > > I'm writing a wrapper around libav. > > https://github.com/jonno85uk/mediahandling/tree/Issue4_encoding > > I know what was causing this condition, avformat_write_header() hadn't > > been called at that time.

Re: [FFmpeg-devel] Segfault calling av_interleaved_write_frame

2020-01-19 Thread Nicolas George
Jonathan Noble (12020-01-19): > I'm writing a wrapper around libav. > https://github.com/jonno85uk/mediahandling/tree/Issue4_encoding > I know what was causing this condition, avformat_write_header() hadn't > been called at that time. Calling avformat_write_header() is not optional, writing frame

Re: [FFmpeg-devel] Segfault calling av_interleaved_write_frame

2020-01-19 Thread Jonathan Noble
On Sat, 18 Jan 2020 at 22:20, Nicolas George wrote: > Jonathan Noble (12020-01-18): > > Oh, it wasn't via ffmpeg. I was using the library. What is the correct > dev > > mailing list? > > Probably. We would need to see the code with the sample, to be sure > where the bug lies. > I'm writing a wrap

Re: [FFmpeg-devel] Segfault calling av_interleaved_write_frame

2020-01-18 Thread Andreas Rheinhardt
On Sat, Jan 18, 2020 at 11:18 PM Jonathan Noble wrote: > Oh, it wasn't via ffmpeg. I was using the library. What is the correct dev > mailing list? > > Your patch was for FFmpeg itself and so this is the right mailing list. But you should nevertheless give us enough information so that we can rep

Re: [FFmpeg-devel] Segfault calling av_interleaved_write_frame

2020-01-18 Thread Nicolas George
Jonathan Noble (12020-01-18): > Oh, it wasn't via ffmpeg. I was using the library. What is the correct dev > mailing list? Probably. We would need to see the code with the sample, to be sure where the bug lies. > On Sat, 18 Jan 2020 at 21:45, Andreas Rheinhardt < > andreas.rheinha...@gmail.com> w

Re: [FFmpeg-devel] Segfault calling av_interleaved_write_frame

2020-01-18 Thread Jonathan Noble
Oh, it wasn't via ffmpeg. I was using the library. What is the correct dev mailing list? On Sat, 18 Jan 2020 at 21:45, Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > On Sat, Jan 18, 2020 at 10:40 PM Jonathan Noble > wrote: > > > Hello, > > > > I found I was getting sigsegv when call

Re: [FFmpeg-devel] Segfault calling av_interleaved_write_frame

2020-01-18 Thread Andreas Rheinhardt
On Sat, Jan 18, 2020 at 10:40 PM Jonathan Noble wrote: > Hello, > > I found I was getting sigsegv when calling av_interleaved_write_frame(). > > From a18f4cb5b86392c5c161878daea8e4b1204881eb Mon Sep 17 00:00:00 2001 > From: jon noble > Date: Sat, 18 Jan 2020 21:33:11 + > Subject: [PATCH] lib

[FFmpeg-devel] Segfault calling av_interleaved_write_frame

2020-01-18 Thread Jonathan Noble
Hello, I found I was getting sigsegv when calling av_interleaved_write_frame(). From a18f4cb5b86392c5c161878daea8e4b1204881eb Mon Sep 17 00:00:00 2001 From: jon noble Date: Sat, 18 Jan 2020 21:33:11 + Subject: [PATCH] libavformat/mux: prevent segfault in compute_muxer_pkt_fields() --- lib