Re: [FFmpeg-devel] Reviews (was: lavc: prefer the mp3float decoder to the mp3 decoder)

2018-04-01 Thread Nicolas George
Rostislav Pehlivanov (2018-04-01): > Backlogs are a thing. Backlogs are a waste of time. IRC discussions are conducted in direct and barely readable afterwards. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-dev

Re: [FFmpeg-devel] Reviews (was: lavc: prefer the mp3float decoder to the mp3 decoder)

2018-04-01 Thread Rostislav Pehlivanov
On 1 April 2018 at 15:33, Nicolas George wrote: > Rostislav Pehlivanov (2018-04-01): > > Please go on IRC, its where most developers talk, exchange ideas, > > information, discuss patches and so on. > > I do not have time to go on IRC. The place where most developers talk, > exchange ideas, infor

Re: [FFmpeg-devel] Reviews (was: lavc: prefer the mp3float decoder to the mp3 decoder)

2018-04-01 Thread Nicolas George
Rostislav Pehlivanov (2018-04-01): > Please go on IRC, its where most developers talk, exchange ideas, > information, discuss patches and so on. I do not have time to go on IRC. The place where most developers talk, exchange ideas, information, discuss patches and so on is the mailing-list. IRC ha

Re: [FFmpeg-devel] Reviews (was: lavc: prefer the mp3float decoder to the mp3 decoder)

2018-04-01 Thread Rostislav Pehlivanov
On 1 April 2018 at 13:24, Nicolas George wrote: > Rostislav Pehlivanov (2018-04-01): > > > lgtm > > > Thanks, pushed > > I think some clarification is required about reviews. > > "LGTM" means "looks good to me". I insist: "me". When Paul writes > "LGTM", it means the patch looks good to Paul, not

[FFmpeg-devel] Reviews (was: lavc: prefer the mp3float decoder to the mp3 decoder)

2018-04-01 Thread Nicolas George
Rostislav Pehlivanov (2018-04-01): > > lgtm > Thanks, pushed I think some clarification is required about reviews. "LGTM" means "looks good to me". I insist: "me". When Paul writes "LGTM", it means the patch looks good to Paul, not anybody else. If Paul is the maintainer of the affected piece o