Re: [FFmpeg-devel] Request for review - x265 User Data Unregistered SEI patch

2021-07-12 Thread Brad Hards
On Sunday, 11 July 2021 10:01:47 PM AEST Derek Buitenhuis wrote: > Can you amend the commit message to contain the reasoning from [1]? Amended. > A quick review: > > +void *sei_data; > > +int sei_data_size; > > I don't see sei_data freed anywhere at the end of decoding? Fixed in v2. Inclu

Re: [FFmpeg-devel] Request for review - x265 User Data Unregistered SEI patch

2021-07-11 Thread Timo Rothenpieler
On 11.07.2021 14:01, Derek Buitenhuis wrote: Hi Brad, On 7/8/2021 4:31 AM, Brad Hards wrote: About a month ago, I submitted a patch to add User Data Unregistered SEI writing to the x265 implementation. See http://ffmpeg.org/pipermail/ffmpeg-devel/2021-June/280978.html[1] and https://patchwork.

Re: [FFmpeg-devel] Request for review - x265 User Data Unregistered SEI patch

2021-07-11 Thread Derek Buitenhuis
Hi Brad, On 7/8/2021 4:31 AM, Brad Hards wrote: > About a month ago, I submitted a patch to add User Data Unregistered SEI > writing to the x265 implementation. > > See http://ffmpeg.org/pipermail/ffmpeg-devel/2021-June/280978.html[1] > and > https://patchwork.ffmpeg.org/project/ffmpeg/patch/202

[FFmpeg-devel] Request for review - x265 User Data Unregistered SEI patch

2021-07-07 Thread Brad Hards
Hi, About a month ago, I submitted a patch to add User Data Unregistered SEI writing to the x265 implementation. See http://ffmpeg.org/pipermail/ffmpeg-devel/2021-June/280978.html[1] and https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210605102028.15571-2-br...@frogmouth.net/[2] If this i