Re: [FFmpeg-devel] Question regarding seemingly superfluous fourcc checks

2016-01-07 Thread Mats Peterson
On 01/07/2016 11:47 AM, Carl Eugen Hoyos wrote: There is a small chance for false positives, but it's probably negligible. Feel free to fix it. The non-FFmpeg sample is: http://samples.ffmpeg.org/Matroska/switzler084d_dl.mkv Carl Eugen Thanks, Carl. Interesting, this file seems to be muxed

Re: [FFmpeg-devel] Question regarding seemingly superfluous fourcc checks

2016-01-07 Thread Mats Peterson
On 01/07/2016 11:22 AM, Mats Peterson wrote: So we'd better keep them, I guess. There is a small chance for false positives, but it's probably negligible. Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] Question regarding seemingly superfluous fourcc checks

2016-01-07 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: > Are the following kludges for A_QUICKTIME and > V_QUICKTIME ways to accommodate old broken Matroska > files that FFmpeg wrote in the past? It dates back to f009e36f75bc137167a26356305d2c3eb83cac68 It is possible that very old matroska files exist that neede

[FFmpeg-devel] Question regarding seemingly superfluous fourcc checks

2016-01-07 Thread Mats Peterson
Are the following kludges for A_QUICKTIME and V_QUICKTIME ways to accommodate old broken Matroska files that FFmpeg wrote in the past? I'm asking because in normal cases, the fourcc in A_QUICKTIME and V_QUICKTIME always starts at offset 4, without exception. A_QUICKTIME: if (ff_codec_get_id(f