Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-04 Thread Ivan Uskov
Hello Ronald, Tuesday, August 4, 2015, 5:24:45 AM, you wrote: RSB> Hi Ivan, RSB> On Mon, Aug 3, 2015 at 4:50 PM, Ivan Uskov wrote: >> Hello Ronald, >> >> Monday, August 3, 2015, 11:37:22 PM, you wrote: >> >> RSB> On Mon, Aug 3, 2015 at 3:25 PM, Ivan Uskov >> wrote: >> >> >> By the way, about

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ronald S. Bultje
Hi Ivan, On Mon, Aug 3, 2015 at 4:50 PM, Ivan Uskov wrote: > Hello Ronald, > > Monday, August 3, 2015, 11:37:22 PM, you wrote: > > RSB> On Mon, Aug 3, 2015 at 3:25 PM, Ivan Uskov > wrote: > > >> By the way, about old implementation which "worked fine". > >> It just did drop all buffered frames

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ivan Uskov
Hello Ronald, Monday, August 3, 2015, 11:37:22 PM, you wrote: RSB> On Mon, Aug 3, 2015 at 3:25 PM, Ivan Uskov wrote: >> By the way, about old implementation which "worked fine". >> It just did drop all buffered frames at decoder re-init on new >> sequence header, there is nice comment inside ol

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ronald S. Bultje
Hi, On Mon, Aug 3, 2015 at 3:25 PM, Ivan Uskov wrote: > By the way, about old implementation which "worked fine". > It just did drop all buffered frames at decoder re-init on new > sequence header, there is nice comment inside old qsvdec_h264.c: > /* TODO: flush delayed frames on reinit */ Eac

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ivan Uskov
Hello wm4, Monday, August 3, 2015, 10:33:30 PM, you wrote: w> I was under the impression that the original Libav code handled this w> correctly. Unfortunately not, you can still see this comment at line 371 https://git.libav.org/?p=libav.git;a=blob;f=libavcodec/qsvdec.c and there is no any flush

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 9:33 PM, wm4 wrote: > On Mon, 3 Aug 2015 22:25:20 +0300 > Ivan Uskov wrote: > >> Hello Michael, Hendrik, >> >> I would like to make sure about following moment regarding handling of >> sequence header changing. The decoder has buffering of decoded frames, >> so when new fra

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread wm4
On Mon, 3 Aug 2015 22:25:20 +0300 Ivan Uskov wrote: > Hello Michael, Hendrik, > > I would like to make sure about following moment regarding handling of > sequence header changing. The decoder has buffering of decoded frames, > so when new frame dimensions are detected we can not just reset > de

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ivan Uskov
Hello Michael, Hendrik, I would like to make sure about following moment regarding handling of sequence header changing. The decoder has buffering of decoded frames, so when new frame dimensions are detected we can not just reset decoder, we should to deffer re-init and switch decoder to some "fl

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ivan Uskov
Hello Hendrik, Thank you very much for the bugreport, I believe I will able to fix all these issues quick. In general all these issues are known and in my todo list. Monday, August 3, 2015, 3:18:04 PM, you wrote: HL> Hey, HL> after a discussion on IRC about the declining quality of the QSV HL

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread wm4
On Mon, 3 Aug 2015 14:18:04 +0200 Hendrik Leppkes wrote: > Hey, > > after a discussion on IRC about the declining quality of the QSV > decoders, I decided to do actual tests and document the results, so we > can get these fixed. > > A lot of these issues are regressions from recent changes, and

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 02:18:04PM +0200, Hendrik Leppkes wrote: > Hey, > > after a discussion on IRC about the declining quality of the QSV > decoders, I decided to do actual tests and document the results, so we > can get these fixed. > > A lot of these issues are regressions from recent change

[FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Hendrik Leppkes
Hey, after a discussion on IRC about the declining quality of the QSV decoders, I decided to do actual tests and document the results, so we can get these fixed. A lot of these issues are regressions from recent changes, and work fine in the original qsv decoders merged from libav, so they should