Re: [FFmpeg-devel] Pull requests

2018-02-27 Thread Bjorn Roche
On Tue, Feb 27, 2018 at 11:55 AM, James Almer wrote: > On 2/27/2018 1:28 PM, Bjorn Roche wrote: > > On Tue, Feb 27, 2018 at 10:34 AM, wm4 wrote: > > > > According to Carl Eugen Hoyos: "This is Clément's code, he has to review > > your patch." > > He's on vacations, so that'd explain why he hasn'

Re: [FFmpeg-devel] Pull requests

2018-02-27 Thread James Almer
On 2/27/2018 1:28 PM, Bjorn Roche wrote: > On Tue, Feb 27, 2018 at 10:34 AM, wm4 wrote: > >> On Tue, 27 Feb 2018 10:25:17 -0500 >> Bjorn Roche wrote: >> >>> On Tue, Feb 27, 2018 at 5:47 AM, wm4 wrote: >>> On Mon, 26 Feb 2018 17:15:26 -0500 Bjorn Roche wrote: > Okay, thanks N

Re: [FFmpeg-devel] Pull requests

2018-02-27 Thread Paul B Mahol
On 2/27/18, Bjorn Roche wrote: > On Tue, Feb 27, 2018 at 10:34 AM, Paul B Mahol wrote: > >> On 2/27/18, Bjorn Roche wrote: >> > On Tue, Feb 27, 2018 at 5:47 AM, wm4 wrote: >> > >> >> On Mon, 26 Feb 2018 17:15:26 -0500 >> >> Bjorn Roche wrote: >> >> >> >> > Okay, thanks Nicolas. >> >> > >> >> >

Re: [FFmpeg-devel] Pull requests

2018-02-27 Thread Bjorn Roche
On Tue, Feb 27, 2018 at 10:34 AM, Paul B Mahol wrote: > On 2/27/18, Bjorn Roche wrote: > > On Tue, Feb 27, 2018 at 5:47 AM, wm4 wrote: > > > >> On Mon, 26 Feb 2018 17:15:26 -0500 > >> Bjorn Roche wrote: > >> > >> > Okay, thanks Nicolas. > >> > > >> > I already submitted a patch to the mailing

Re: [FFmpeg-devel] Pull requests

2018-02-27 Thread Nicolas George
Bjorn Roche (2018-02-27): > According to Carl Eugen Hoyos: "This is Clément's code, he has to review > your patch." Then reply to Carl Eugen's mail to say "Clément does not seem to care these days", to re-start the discussion. Regards, -- Nicolas George signature.asc Description: Digital si

Re: [FFmpeg-devel] Pull requests

2018-02-27 Thread Bjorn Roche
On Tue, Feb 27, 2018 at 10:34 AM, wm4 wrote: > On Tue, 27 Feb 2018 10:25:17 -0500 > Bjorn Roche wrote: > > > On Tue, Feb 27, 2018 at 5:47 AM, wm4 wrote: > > > > > On Mon, 26 Feb 2018 17:15:26 -0500 > > > Bjorn Roche wrote: > > > > > > > Okay, thanks Nicolas. > > > > > > > > I already submitted

Re: [FFmpeg-devel] Pull requests

2018-02-27 Thread Paul B Mahol
On 2/27/18, Bjorn Roche wrote: > On Tue, Feb 27, 2018 at 5:47 AM, wm4 wrote: > >> On Mon, 26 Feb 2018 17:15:26 -0500 >> Bjorn Roche wrote: >> >> > Okay, thanks Nicolas. >> > >> > I already submitted a patch to the mailing list a few months ago, I was >> > just hoping for an easier way to keep it

Re: [FFmpeg-devel] Pull requests

2018-02-27 Thread wm4
On Tue, 27 Feb 2018 10:25:17 -0500 Bjorn Roche wrote: > On Tue, Feb 27, 2018 at 5:47 AM, wm4 wrote: > > > On Mon, 26 Feb 2018 17:15:26 -0500 > > Bjorn Roche wrote: > > > > > Okay, thanks Nicolas. > > > > > > I already submitted a patch to the mailing list a few months ago, I was > > > just h

Re: [FFmpeg-devel] Pull requests

2018-02-27 Thread Bjorn Roche
On Tue, Feb 27, 2018 at 5:47 AM, wm4 wrote: > On Mon, 26 Feb 2018 17:15:26 -0500 > Bjorn Roche wrote: > > > Okay, thanks Nicolas. > > > > I already submitted a patch to the mailing list a few months ago, I was > > just hoping for an easier way to keep it fresh since it's gone stale, > and I > >

Re: [FFmpeg-devel] Pull requests

2018-02-27 Thread wm4
On Mon, 26 Feb 2018 17:15:26 -0500 Bjorn Roche wrote: > Okay, thanks Nicolas. > > I already submitted a patch to the mailing list a few months ago, I was > just hoping for an easier way to keep it fresh since it's gone stale, and I > had some more fixes for it. Just ping it a few times or resen

Re: [FFmpeg-devel] Pull requests

2018-02-26 Thread Lou Logan
On Mon, Feb 26, 2018, at 12:39 PM, Bjorn Roche wrote: > > I have a patch I'd like to submit -- can I submit a PR on GitHub, or no? The main problem with github and such is that all development discussions and reviews occur at one location: the ffmpeg-devel mailing list. PRs are therefore out of

Re: [FFmpeg-devel] Pull requests

2018-02-26 Thread Bjorn Roche
Okay, thanks Nicolas. I already submitted a patch to the mailing list a few months ago, I was just hoping for an easier way to keep it fresh since it's gone stale, and I had some more fixes for it. bjorn On Mon, Feb 26, 2018 at 4:49 PM, Nicolas George wrote: > Bjorn Roche (2018-02-26): > > - C

Re: [FFmpeg-devel] Pull requests

2018-02-26 Thread James Almer
On 2/26/2018 6:39 PM, Bjorn Roche wrote: > Hey there, > > Your docs (https://ffmpeg.org/developer.html) say: > > There are 3 ways by which code gets into FFmpeg. > > - Submitting patches to the main developer mailing list. See Submitting > patches for details. > - Directly committing changes to

Re: [FFmpeg-devel] Pull requests

2018-02-26 Thread Nicolas George
Bjorn Roche (2018-02-26): > - Committing changes to a git clone, for example on github.com or > gitorious.org. And asking us to merge these changes. Note that it does not say how you are supposed to "ask". You are supposed to ask on the mailing-list. > I have a patch I'd like to submit -- can I s

[FFmpeg-devel] Pull requests

2018-02-26 Thread Bjorn Roche
Hey there, Your docs (https://ffmpeg.org/developer.html) say: There are 3 ways by which code gets into FFmpeg. - Submitting patches to the main developer mailing list. See Submitting patches for details. - Directly committing changes to the main tree. - Committing changes to a git clone, for exa