Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-08-01 Thread Christopher Degawa
Doesn't break msys2 builds, so it's okay to me. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-08-01 Thread Carl Eugen Hoyos
> > Am 01.08.2020 um 08:47 schrieb Julio César Rocha : > please find out what top-posting means and avoid it here. Ping, this should not need more than a few minutes. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/m

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-08-01 Thread Carl Eugen Hoyos
Am Sa., 1. Aug. 2020 um 12:34 Uhr schrieb Timo Rothenpieler : > > On 01.08.2020 08:47, Julio César Rocha wrote: > > Friendly ping. > > > > Are these changes acceptable now? > > > > I still don't see why they are neccesary. I did a test-build just > yesterday with current git master, and it succeede

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-08-01 Thread Julio César Rocha
I'll try again. It did not work for me as of version 4.2.2. Maybe a more recent change has fixed it... On Sat, Aug 1, 2020 at 3:34 AM Timo Rothenpieler wrote: > On 01.08.2020 08:47, Julio César Rocha wrote: > > Friendly ping. > > > > Are these changes acceptable now? > > > > I still don't see w

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-08-01 Thread Timo Rothenpieler
On 01.08.2020 08:47, Julio César Rocha wrote: Friendly ping. Are these changes acceptable now? I still don't see why they are neccesary. I did a test-build just yesterday with current git master, and it succeeded just fine with --toolchain=msvc in WSL launched via msvc cli. ___

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-08-01 Thread Carl Eugen Hoyos
> Am 01.08.2020 um 08:47 schrieb Julio César Rocha : > > Friendly ping. > > Are these changes acceptable now? Please allow more than 24 hours reaction time and please find out what top-posting means and avoid it here. Carl Eugen ___ ffmpeg-devel ma

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-07-31 Thread Julio César Rocha
Friendly ping. Are these changes acceptable now? On Fri, Jul 31, 2020 at 1:35 AM Julio César Rocha wrote: > Understood, thanks! > > Here are the updated patches. > > On Fri, Jul 31, 2020 at 1:07 AM zhilizhao wrote: > >> >> >> > On Jul 31, 2020, at 3:19 PM, Julio César Rocha >> wrote: >> > >>

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-07-31 Thread Julio César Rocha
Understood, thanks! Here are the updated patches. On Fri, Jul 31, 2020 at 1:07 AM zhilizhao wrote: > > > > On Jul 31, 2020, at 3:19 PM, Julio César Rocha > wrote: > > > > I didn't find any documentation that refers to building with WSL. > > Can builds with WSL be achieved without any patching?

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-07-31 Thread zhilizhao
> On Jul 31, 2020, at 3:19 PM, Julio César Rocha wrote: > > I didn't find any documentation that refers to building with WSL. > Can builds with WSL be achieved without any patching? > > Also, how should I split the patch, if it's only modifying one file? Modify a part of the file, git add &&

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-07-31 Thread Julio César Rocha
I didn't find any documentation that refers to building with WSL. Can builds with WSL be achieved without any patching? Also, how should I split the patch, if it's only modifying one file? On Thu, Jul 30, 2020 at 11:52 PM Carl Eugen Hoyos wrote: > > > > Am 31.07.2020 um 06:59 schrieb Julio Césa

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-07-30 Thread Carl Eugen Hoyos
> Am 31.07.2020 um 06:59 schrieb Julio César Rocha : > > Attaching git format-patch change. > > Allows building FFmpeg on Windows using bash.exe provided by WSL, as an > alternative to MSYS. The commit message is not ok as many people regularly build with wsl. And please split the patch. Carl

[FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

2020-07-30 Thread Julio César Rocha
Attaching git format-patch change. Allows building FFmpeg on Windows using bash.exe provided by WSL, as an alternative to MSYS. 0001-Add-support-for-WSL.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg