Thanks for cleaning that up!
On Thu, Jan 3, 2019 at 9:32 AM James Almer wrote:
>
> On 1/3/2019 1:12 PM, Oliver Collyer wrote:
> > Version created using git format-patch.
>
> Applied, thanks.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
>
On 1/3/2019 1:12 PM, Oliver Collyer wrote:
> Version created using git format-patch.
Applied, thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Version created using git format-patch.
0001-Fixed-some-minor-memory-leaks.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
It was the file that was produced after a commit using git format-patch -n
HEAD^1
I’m not all that familiar with these tools but that is what I typed and I
attached the file it produced. This was using Windows.
>> On 3 Jan 2019, at 18:42, James Almer wrote:
>>
>> On 1/3/2019 4:59 AM, Oliver C
On 1/3/2019 4:59 AM, Oliver Collyer wrote:
>
>
>> On 2 Jan 2019, at 17:52, Oliver Collyer wrote:
>>
>>
>>
>>> On 2 Jan 2019, at 11:30, Oliver Collyer wrote:
>>>
>>>
>>>
On 1 Jan 2019, at 23:58, James Almer wrote:
On 1/1/2019 5:01 PM, Oliver Collyer wrote:
> -- Block
> On 2 Jan 2019, at 17:52, Oliver Collyer wrote:
>
>
>
>> On 2 Jan 2019, at 11:30, Oliver Collyer wrote:
>>
>>
>>
>>> On 1 Jan 2019, at 23:58, James Almer wrote:
>>>
>>> On 1/1/2019 5:01 PM, Oliver Collyer wrote:
-- Block 26224 at 0x74240F70: 151 bytes --
>>
> On 2 Jan 2019, at 11:30, Oliver Collyer wrote:
>
>
>
>> On 1 Jan 2019, at 23:58, James Almer wrote:
>>
>> On 1/1/2019 5:01 PM, Oliver Collyer wrote:
>>> -- Block 26224 at 0x74240F70: 151 bytes --
>>> Leak Hash: 0x357CD5AF, Count: 1, Total 151 bytes
>>> Call Stack (
> On 1 Jan 2019, at 23:58, James Almer wrote:
>
> On 1/1/2019 5:01 PM, Oliver Collyer wrote:
>> -- Block 26224 at 0x74240F70: 151 bytes --
>> Leak Hash: 0x357CD5AF, Count: 1, Total 151 bytes
>> Call Stack (TID 55752):
>>ucrtbased.dll!aligned_malloc()
>>c:\ffmpe
On Tue, Jan 01, 2019 at 18:22:42 -0300, James Almer wrote:
> >> +if (!this)
> >> +return
> >> +av_freep(&this->imemvtbl);
> >
> > Do add a semicolon after "return" for good measure. ;)
>
> Huh, curious, gcc 8 (mingw-w64) compiled this just fine without the
> semicolon.
Oh my. ;-)
On 1/1/2019 6:16 PM, Moritz Barsnick wrote:
> On Tue, Jan 01, 2019 at 17:58:42 -0300, James Almer wrote:
>> Does the attached (untested) patch fix these two for you?
> [...]
>> +if (!this)
>> +return
>> +av_freep(&this->imemvtbl);
>
> Do add a semicolon after "return" for good meas
On Tue, Jan 01, 2019 at 17:58:42 -0300, James Almer wrote:
> Does the attached (untested) patch fix these two for you?
[...]
> +if (!this)
> +return
> +av_freep(&this->imemvtbl);
Do add a semicolon after "return" for good measure. ;)
Moritz
On 1/1/2019 5:01 PM, Oliver Collyer wrote:
> -- Block 26224 at 0x74240F70: 151 bytes --
> Leak Hash: 0x357CD5AF, Count: 1, Total 151 bytes
> Call Stack (TID 55752):
> ucrtbased.dll!aligned_malloc()
> c:\ffmpeg\source\ffmpeg\libavutil\mem.c (90): emu-server.exe!av
Greetings
I'm reporting some possible memory leaks in the dshow format code.
As far as I can tell I'm freeing everything I should; the leaks come via
allocations made during av_format_open_input and I can confirm that in my code
I calling av_format_close_input when I'm done, as per the document
13 matches
Mail list logo
