Thanks for the tips Andriy.
To make it easier for future new contributors I took the time to update
developers.texi with the information I got from this thread, and revamp the
chapter about submitting patches.
Feedback is most welcome.
Best regards,
Manolis
On Sun, 5 Jul 2020 at 20:56, Andriy
On Sun, 05. Jul 20:34, Manolis Stamatogiannakis wrote:
> On Sun, 5 Jul 2020 at 15:48, Hongcheng Zhong
> wrote:
>
> >
> > You can use `git format-patch -v -n` to get patches like [PATCH
> > v2 1/20]. See git-format-patch documentation for more details.
> >
> >
> That didn't quite work.
>
> I used
On Sun, 5 Jul 2020 at 15:48, Hongcheng Zhong
wrote:
>
> You can use `git format-patch -v -n` to get patches like [PATCH
> v2 1/20]. See git-format-patch documentation for more details.
>
>
That didn't quite work.
I used "git format-patch -s -n -v3 --to ffmpeg-devel@ffmpeg.org
HEAD~2..HEAD" and "
Thanks for the responses Hongcheng and Steinar!
I'll use '-n' with git format-patch if I need to resubmit. Patches already
work as Steinar describes.
In the meantime patch 2/3 found its way to patchwork. The delay was
probably due to some email processing hiccup.
So all is good!
Cheers,
Manolis
On Sun, Jul 05, 2020 at 03:42:34PM +0200, Manolis Stamatogiannakis wrote:
> Q2: In a patchset consisting of several commits, is each commit expected to
> be "standalone"? I.e. does it have to apply cleanly without depending on
> the previous commits in the patchset?
No, but it has to compile and w
On Sun, 2020-07-05 at 15:42 +0200, Manolis Stamatogiannakis wrote:
> Hello,
>
> I'm trying to submit a patch for adding a "shift" option to
> subtitles/ass
> filters. Initial submission was ok, but resubmitting after addressing
> some
> emails didn't go as expected.
>
> I have the following two q
Hello,
I'm trying to submit a patch for adding a "shift" option to subtitles/ass
filters. Initial submission was ok, but resubmitting after addressing some
emails didn't go as expected.
I have the following two questions on the process:
Q1: How do you get the "v2" label when you resubmit a patch
Hi,
I just prepared a patch and I've also written a quite comprehensive explanation
(about 60 lines of text).
Should I put all the text into the git commit or should I use a shortened
version for the commit and post the long version to this list only?
Thanks,
softworkz
___
