Re: [FFmpeg-devel] Patch for libavcodec/exr.c implementing B44 compression technique

2015-03-18 Thread greeshma
On Wed, Mar 18, 2015 at 9:37 PM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 3/18/2015 2:20 PM, Derek Buitenhuis wrote: > > Also, if you wrote this code, this copyright is both incorrect > > and makes it non-free. > > Hi, > Thanks for pointing out the mistakes. So after checking,

Re: [FFmpeg-devel] Patch for libavcodec/exr.c implementing B44 compression technique

2015-03-18 Thread Derek Buitenhuis
On 3/18/2015 2:20 PM, Derek Buitenhuis wrote: > Also, if you wrote this code, this copyright is both incorrect > and makes it non-free. Hi, So after checking, the vast majority of this patch is copy & pasted from OpenEXR. On that note, a few points: 1. You have no properly recreated the license

Re: [FFmpeg-devel] Patch for libavcodec/exr.c implementing B44 compression technique

2015-03-18 Thread Derek Buitenhuis
On 3/18/2015 2:08 PM, greeshma wrote: > The .diff file is also attached henceforth.Please have a look. This is still not a git-format patch as required and asked for by Michael. Also, the style and formatting is all over the place - that is, there is no consistent style or formatting at all. Plea

[FFmpeg-devel] Patch for libavcodec/exr.c implementing B44 compression technique

2015-03-18 Thread greeshma
The .diff file is also attached henceforth.Please have a look. diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 6251fb7..cc15a3a 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -770,6 +770,163 @@ static int piz_uncompress(EXRContext *s, const uint8_t *src, int ssize, return 0;