Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-07 Thread David Fletcher
On Fri May 6 21:29:51 EEST 2022 Lynne dev at lynne.ee wrote: > I disagree with this patch. The native decoder should be fixed instead, > or if it's not able to be fixed, users should use specialized libraries. > We're not adding a yet another decoding library to fix an issue on > very old ARM chip

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-06 Thread Lynne
5 May 2022, 01:47 by da...@megapico.co.uk: >> Andreas Rheinhardt wrote: >> >> David Fletcher: >> > Following today's posts about help with submitting patches I realised I >> > sent the libmad patch yesterday in the wrong format. Apologies, I was >> > not familiar with the git format patches. >> >

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-04 Thread David Fletcher
> Andreas Rheinhardt wrote: > > David Fletcher: > > Following today's posts about help with submitting patches I realised I > > sent the libmad patch yesterday in the wrong format. Apologies, I was > > not familiar with the git format patches. > > > > Hopefully the attached version is now in the

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-03 Thread Andreas Rheinhardt
David Fletcher: > Following today's posts about help with submitting patches I realised I > sent the libmad patch yesterday in the wrong format. Apologies, I was > not familiar with the git format patches. > > Hopefully the attached version is now in the correct format against the > current master

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-03 Thread David Fletcher
Following today's posts about help with submitting patches I realised I sent the libmad patch yesterday in the wrong format. Apologies, I was not familiar with the git format patches. Hopefully the attached version is now in the correct format against the current master branch. The bug report abo

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread David Fletcher
On 2/5/2022, "Martin Storsjö" martin at martin.st wrote: > That sounds like there's an issue with some of the ARM implementations of > DSP functions, that only exists in implementations for less featureful ARM > instruction sets. > > (It could theoretically be a compiler bug also but I think it

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread Martin Storsjö
On Mon, 2 May 2022, David Fletcher wrote: On 2/5/2022, "Nicolas George" wrote: Is there a trac ticket? If not, please fill one: we would not want to keep that bug. Regards, -- Nicolas George Hi Nicolas, I'll prepare a test case to demonstrate the issue and fill in a ticket. As far as I c

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread Neal Gompa
On Mon, May 2, 2022 at 1:42 PM David Fletcher wrote: > > On 2/5/2022, "Paul B Mahol" wrote: > >Only patches for master are accepted. > > > >No more wrappers. > > > >Thanks. > > Hi Paul, > > Please find attached the libmad MP3 decoding patch against the master > (ffmpeg-master-b67572c). > > I'm no

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread Timo Rothenpieler
On 02.05.2022 19:45, David Fletcher wrote: On 2/5/2022, "Nicolas George" wrote: Is there a trac ticket? If not, please fill one: we would not want to keep that bug. Regards, -- Nicolas George Hi Nicolas, I'll prepare a test case to demonstrate the issue and fill in a ticket. As far as I

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread David Fletcher
On 2/5/2022, "Nicolas George" wrote: >Is there a trac ticket? If not, please fill one: we would not want to >keep that bug. > >Regards, > >-- > Nicolas George Hi Nicolas, I'll prepare a test case to demonstrate the issue and fill in a ticket. As far as I can tell this is an issue affecting old

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread David Fletcher
On 2/5/2022, "Paul B Mahol" wrote: >Only patches for master are accepted. > >No more wrappers. > >Thanks. Hi Paul, Please find attached the libmad MP3 decoding patch against the master (ffmpeg-master-b67572c). I'm not sure what "No more wrappers" means? Best regards, David. diff -Nur ./ffmpeg-

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread Nicolas George
David Fletcher (12022-05-01): > I hope that this is useful. Some context - I found the FFmpeg inbuild > fixed point MP3 decoder produced very distorted audio for low bitrate > streams (56k/s and lower). Is there a trac ticket? If not, please fill one: we would not want to keep that bug. Regards,

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread Paul B Mahol
Only patches for master are accepted. No more wrappers. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

[FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-01 Thread David Fletcher
Please find attached a patch adding support for MP3 decoding using libmad. This is against release ffmpeg-5.0.1, and works for libmad 0.15.1b (the most recent available). I hope that this is useful. Some context - I found the FFmpeg inbuild fixed point MP3 decoder produced very distorted audio for