Re: [FFmpeg-devel] Lossy GIF encoding

2019-02-17 Thread Tomas Härdin
fre 2019-02-15 klockan 16:45 + skrev Kornel: > > > Alternatively, would it be OK to create a separate codec just for > > > lossy compression? I would create a new GIF codec, define it under a > > > new name, and declare it always takes AV_PIX_FMT_RGB24 or > > > AV_PIX_FMT_RGBA. Is that a good a

Re: [FFmpeg-devel] Lossy GIF encoding

2019-02-15 Thread Moritz Barsnick
On Fri, Feb 15, 2019 at 09:01:40 +, Kornel wrote: > The main problem I have now is that the existing GIF codec receives > frames already converted to AV_PIX_FMT_RGB8 or similar 8-bit format. > When working with 8bpp heavily-dithered input, the lossy compression > struggles to find runs of simi

Re: [FFmpeg-devel] Lossy GIF encoding

2019-02-15 Thread James Darnley
On 2019-02-15 10:01, Kornel wrote: > libavcodec/gif.c in ff_gif_encoder.pix_fmts seems to passively declare types > of pixel formats it accepts. If you want to experiment you can change that so it accepts rgb (also or only). Then you can implement and test what you want, then you can ask about s

Re: [FFmpeg-devel] Lossy GIF encoding

2019-02-15 Thread Paul B Mahol
On 2/15/19, Kornel wrote: > >>> Alternatively, would it be OK to create a separate codec just for >>> lossy compression? I would create a new GIF codec, define it under a >>> new name, and declare it always takes AV_PIX_FMT_RGB24 or >>> AV_PIX_FMT_RGBA. Is that a good approach? >> >> This sounds m

Re: [FFmpeg-devel] Lossy GIF encoding

2019-02-15 Thread Kornel
>> Alternatively, would it be OK to create a separate codec just for >> lossy compression? I would create a new GIF codec, define it under a >> new name, and declare it always takes AV_PIX_FMT_RGB24 or >> AV_PIX_FMT_RGBA. Is that a good approach? > > This sounds more like something that belongs i

Re: [FFmpeg-devel] Lossy GIF encoding

2019-02-15 Thread Tomas Härdin
fre 2019-02-15 klockan 09:01 + skrev Kornel: > Hello! > > I'm working on implementing lossy gif encoding, and I'd like to hear > your opinion on how to best integrate it with ffmpeg in a way that > would be acceptable for inclusion in the project. > > Lossy encoding is done by making LZW use

[FFmpeg-devel] Lossy GIF encoding

2019-02-15 Thread Kornel
Hello! I'm working on implementing lossy gif encoding, and I'd like to hear your opinion on how to best integrate it with ffmpeg in a way that would be acceptable for inclusion in the project. Lossy encoding is done by making LZW use approximate matching, and with the right input it can halve