Re: [FFmpeg-devel] How to correctly use init and uninit

2019-05-14 Thread Ulf Zibis
Am 19.04.19 um 14:35 schrieb Paul B Mahol: >>> You do not need to use loop filter on single png. >> I need real pictures to prove the correctness of my hacking. The >> smptebars is not appopriate to see errors in the output e.g. from mirroring. >> >>> Use something like this: >>> >>> ffmpeg -f lav

Re: [FFmpeg-devel] How to correctly use init and uninit

2019-05-13 Thread Ulf Zibis
Am 19.04.19 um 14:35 schrieb Paul B Mahol: >>> You do not need to use loop filter on single png. >> I need real pictures to prove the correctness of my hacking. The >> smptebars is not appopriate to see errors in the output e.g. from mirroring. >> >>> Use something like this: >>> >>> ffmpeg -f lav

Re: [FFmpeg-devel] How to correctly use init and uninit

2019-04-19 Thread Carl Eugen Hoyos
2019-04-19 14:25 GMT+02:00, Ulf Zibis : > > Am 19.04.19 um 13:38 schrieb Paul B Mahol: >> >> Use either av_freep(&s->filler) or av_free(s->filler). > > It works fine without 'p'. Please use av_freep() for context variables. Carl Eugen ___ ffmpeg-devel m

Re: [FFmpeg-devel] How to correctly use init and uninit

2019-04-19 Thread Paul B Mahol
On 4/19/19, Ulf Zibis wrote: > > Am 19.04.19 um 14:35 schrieb Paul B Mahol: >>> Do I really need the init function, as it has to do nothing in my case? >> If it does nothing, you can safely remove it. > > Thanks! > >>> For performance testing I use the like: >>> -f rawvideo -pix_fmt gray16 -s 400x

Re: [FFmpeg-devel] How to correctly use init and uninit

2019-04-19 Thread Ulf Zibis
Am 19.04.19 um 14:35 schrieb Paul B Mahol: >> Do I really need the init function, as it has to do nothing in my case? > If it does nothing, you can safely remove it. Thanks! >> For performance testing I use the like: >> -f rawvideo -pix_fmt gray16 -s 400x600 -i /dev/zero >> >> Are there doubts i

Re: [FFmpeg-devel] How to correctly use init and uninit

2019-04-19 Thread Paul B Mahol
On 4/19/19, Ulf Zibis wrote: > > Am 19.04.19 um 13:38 schrieb Paul B Mahol: >> >> Use either av_freep(&s->filler) or av_free(s->filler). > > It works fine without 'p'. Thanks! > > Do I really need the init function, as it has to do nothing in my case? If it does nothing, you can safely remove it.

Re: [FFmpeg-devel] How to correctly use init and uninit

2019-04-19 Thread Ulf Zibis
Am 19.04.19 um 13:38 schrieb Paul B Mahol: > > Use either av_freep(&s->filler) or av_free(s->filler). It works fine without 'p'. Thanks! Do I really need the init function, as it has to do nothing in my case? static av_cold int init(AVFilterContext *ctx) { FillBordersContext *s = ctx->priv;

Re: [FFmpeg-devel] How to correctly use init and uninit

2019-04-19 Thread Paul B Mahol
On 4/19/19, Ulf Zibis wrote: > Hi, > > to libavfilter/vf_fillborders.c I've added the following: > === > typedef struct FillBordersContext { > [.] > uint16_t *filler; > > void (*fillborders)(struct FillBordersContext *s, AVFrame *fram

[FFmpeg-devel] How to correctly use init and uninit

2019-04-19 Thread Ulf Zibis
Hi, to libavfilter/vf_fillborders.c I've added the following: === typedef struct FillBordersContext {     [.]     uint16_t *filler;     void (*fillborders)(struct FillBordersContext *s, AVFrame *frame); } FillBordersContext; // following must b