Re: [FFmpeg-devel] Fwd: [PATCH v2] avcodec/h264: fixed qp table attach for h264

2025-06-16 Thread Andreas Rheinhardt
Timothee: > Hello, > > Thank you for the feedback. > > You are right and the changes to h264_slice.c seem redundant. I will > remove that. and run the tests again. > > Should I make two differents commits to change qp_table.c and qp_table.h ? > What I said about unrelated changes applies to th

Re: [FFmpeg-devel] Fwd: [PATCH v2] avcodec/h264: fixed qp table attach for h264

2025-06-16 Thread Timothee
Hello, Thank you for the feedback. You are right and the changes to h264_slice.c seem redundant. I will remove that. and run the tests again. Should I make two differents commits to change qp_table.c and qp_table.h ? Thanks, Timothée On 16/06/2025 à 11:32, Andreas Rheinhardt wrote : Timo

Re: [FFmpeg-devel] Fwd: [PATCH v2] avcodec/h264: fixed qp table attach for h264

2025-06-16 Thread Andreas Rheinhardt
Timothee: > Hello, > > Thank you for the feedback on my first patch. The corruption was likely > caused by my email client's text formatting. > > The patch is attach to prevent any formatting error. > > I have check the patch file applies cleanly using `git am` and verified > that all FATE tests

[FFmpeg-devel] Fwd: [PATCH v2] avcodec/h264: fixed qp table attach for h264

2025-06-16 Thread Timothee
Hello, Thank you for the feedback on my first patch. The corruption was likely caused by my email client's text formatting. The patch is attach to prevent any formatting error. I have check the patch file applies cleanly using `git am` and verified that all FATE tests still pass. Please le