Re: [FFmpeg-devel] Discrepancy between comments for AVX512 flags

2022-08-27 Thread Henrik Gramner
> On Sat, Aug 27, 2022 at 12:04 AM James Darnley wrote: > I think the feature selection is fine as-is, if you want to clarify > the comments go ahead. AVX512 wouldn't be useful with a subset even > smaller then what the plain AVX512 is looking for (there is also no > CPUs with any smaller set, afa

Re: [FFmpeg-devel] Discrepancy between comments for AVX512 flags

2022-08-26 Thread Hendrik Leppkes
On Sat, Aug 27, 2022 at 12:04 AM James Darnley wrote: > > Has there been a discussion about which features should go with which flag? I think the feature selection is fine as-is, if you want to clarify the comments go ahead. AVX512 wouldn't be useful with a subset even smaller then what the plain

[FFmpeg-devel] Discrepancy between comments for AVX512 flags

2022-08-26 Thread James Darnley
While cherry-picking some stuff for avx512 I have noticed that ffmpeg has a discrepancy in the comments for the two avx512 flags. Lets start with the public header libavutil/cpu.h 56│ #define AV_CPU_FLAG_AVX512 0x10 ///< AVX-512 functions: requires OS support even if YMM/ZMM register