Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-16 Thread Aaron Levinson
On 4/16/2017 10:08 AM, Ronald S. Bultje wrote: Hi, On Sun, Apr 16, 2017 at 12:59 PM, Aaron Levinson wrote: I like using this approach, but I think such files should only be added to the build if --disable-optimizations is passed into configure. Or you could detect in configure if the compi

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-16 Thread Ronald S. Bultje
Hi, On Sun, Apr 16, 2017 at 12:59 PM, Aaron Levinson wrote: > I like using this approach, but I think such files should only be added to > the build if --disable-optimizations is passed into configure. > Or you could detect in configure if the compiler supports DCE? Ronald

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-16 Thread Aaron Levinson
On 4/16/2017 8:57 AM, Matt Oliver wrote: On 14 April 2017 at 08:05, Hendrik Leppkes wrote: On Fri, Apr 14, 2017 at 12:00 AM, Ronald S. Bultje wrote: Hi Aaron, On Thu, Apr 13, 2017 at 4:47 PM, Aaron Levinson wrote: #if ARCH_AARCH64 if (ARCH_AARCH64) return ff_get_cpu_flags_aar

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Hendrik Leppkes
On Fri, Apr 14, 2017 at 12:00 AM, Ronald S. Bultje wrote: > Hi Aaron, > > On Thu, Apr 13, 2017 at 4:47 PM, Aaron Levinson > wrote: > >> #if ARCH_AARCH64 >> if (ARCH_AARCH64) >> return ff_get_cpu_flags_aarch64(); >> #endif >> > > If you add #if, at least replace the if with it. #if + i

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Ronald S. Bultje
Hi Aaron, On Thu, Apr 13, 2017 at 4:47 PM, Aaron Levinson wrote: > #if ARCH_AARCH64 > if (ARCH_AARCH64) > return ff_get_cpu_flags_aarch64(); > #endif > If you add #if, at least replace the if with it. #if + if is redundant. > Such a script could be reviewed and checked into the so

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Aaron Levinson
On 4/13/2017 11:04 AM, Matt Oliver wrote: On 14 April 2017 at 03:31, Hendrik Leppkes wrote: On Thu, Apr 13, 2017 at 7:16 PM, Matt Oliver wrote: On 14 April 2017 at 02:11, Rostislav Pehlivanov wrote: On 13 April 2017 at 16:51, wm4 wrote: On Thu, 13 Apr 2017 17:39:57 +1000 Matt Olive

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Matt Oliver
On 14 April 2017 at 03:31, Hendrik Leppkes wrote: > On Thu, Apr 13, 2017 at 7:16 PM, Matt Oliver wrote: > > On 14 April 2017 at 02:11, Rostislav Pehlivanov > wrote: > > > >> > >> > >> On 13 April 2017 at 16:51, wm4 wrote: > >> > >>> On Thu, 13 Apr 2017 17:39:57 +1000 > >>> Matt Oliver wrote:

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Hendrik Leppkes
On Thu, Apr 13, 2017 at 7:16 PM, Matt Oliver wrote: > On 14 April 2017 at 02:11, Rostislav Pehlivanov wrote: > >> >> >> On 13 April 2017 at 16:51, wm4 wrote: >> >>> On Thu, 13 Apr 2017 17:39:57 +1000 >>> Matt Oliver wrote: >>> >>> > On 13 April 2017 at 17:20, Aaron Levinson wrote: >>> > >>> >

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Matt Oliver
On 14 April 2017 at 02:11, Rostislav Pehlivanov wrote: > > > On 13 April 2017 at 16:51, wm4 wrote: > >> On Thu, 13 Apr 2017 17:39:57 +1000 >> Matt Oliver wrote: >> >> > On 13 April 2017 at 17:20, Aaron Levinson wrote: >> > >> > > I wanted to build a debug build of ffmpeg using Visual C++ today

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Rostislav Pehlivanov
On 13 April 2017 at 16:51, wm4 wrote: > On Thu, 13 Apr 2017 17:39:57 +1000 > Matt Oliver wrote: > > > On 13 April 2017 at 17:20, Aaron Levinson wrote: > > > > > I wanted to build a debug build of ffmpeg using Visual C++ today, one > > > without any optimizations. This implies the use of the -O

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread wm4
On Thu, 13 Apr 2017 17:39:57 +1000 Matt Oliver wrote: > On 13 April 2017 at 17:20, Aaron Levinson wrote: > > > I wanted to build a debug build of ffmpeg using Visual C++ today, one > > without any optimizations. This implies the use of the -Od compiler > > option. Unfortunately, I quickly dis

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Matt Oliver
On 13 April 2017 at 17:20, Aaron Levinson wrote: > I wanted to build a debug build of ffmpeg using Visual C++ today, one > without any optimizations. This implies the use of the -Od compiler > option. Unfortunately, I quickly discovered that the build fails soon > after it starts because it can

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Hendrik Leppkes
On Thu, Apr 13, 2017 at 9:20 AM, Aaron Levinson wrote: > I wanted to build a debug build of ffmpeg using Visual C++ today, one > without any optimizations. This implies the use of the -Od compiler option. > Unfortunately, I quickly discovered that the build fails soon after it > starts because it

[FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Aaron Levinson
I wanted to build a debug build of ffmpeg using Visual C++ today, one without any optimizations. This implies the use of the -Od compiler option. Unfortunately, I quickly discovered that the build fails soon after it starts because it can't find certain architecture-specific references. For