Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-31 Thread Michael Niedermayer
On Thu, Aug 31, 2017 at 12:23:04PM -0700, Dale Curtis wrote: > Ping, without the patch in the previous message you can get crashes when > encountering these types of files. will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Modern terrorism, a qui

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-31 Thread Dale Curtis
Ping, without the patch in the previous message you can get crashes when encountering these types of files. - dale On Mon, Aug 28, 2017 at 2:45 PM, Dale Curtis wrote: > On Fri, Aug 25, 2017 at 6:09 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: >> >> This changes the printed duratio

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-28 Thread Dale Curtis
On Fri, Aug 25, 2017 at 6:09 PM, Michael Niedermayer wrote: > > This changes the printed duration start time and bitrate for > MAV_0034.3G2 > see > https://trac.ffmpeg.org/ticket/2757 Thanks, I've restored the ability to query these types of files. That file also reveals the potential for a case

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-25 Thread Michael Niedermayer
On Fri, Aug 25, 2017 at 11:59:51AM -0700, Dale Curtis wrote: > On Fri, Aug 25, 2017 at 5:43 AM, Michael Niedermayer > wrote: > > > > > This patch breaks: > > http://samples.ffmpeg.org/mov/mp4/discont-frag.mp4 > > > > > Hmm, indeed it does. The reason is that we read the sample count from the > st

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-25 Thread Dale Curtis
On Fri, Aug 25, 2017 at 5:43 AM, Michael Niedermayer wrote: > > This patch breaks: > http://samples.ffmpeg.org/mov/mp4/discont-frag.mp4 > > Hmm, indeed it does. The reason is that we read the sample count from the stsz box and then read the trun box. I don't think this block of code has ever been

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-25 Thread Michael Niedermayer
On Mon, Jul 31, 2017 at 04:42:20PM -0700, Dale Curtis wrote: > I'm not convinced my original patch catches all cases. So here's an updated > one which explicitly verifies the contract. > > - dale > > On Mon, Jul 31, 2017 at 2:40 PM, Dale Curtis > wrote: > > > [mov] Bail when invalid sample data

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-24 Thread Dale Curtis
+michael This patch is also necessary now that you've applied the ctts fixes in the previous patch. Thanks. - dale On Fri, Aug 4, 2017 at 4:04 PM, Dale Curtis wrote: > Sample sent privately. I didn't find any non-fuzzer samples that no longer > demux in our Chrome test corpus or in fate. > > -

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-04 Thread Dale Curtis
Sample sent privately. I didn't find any non-fuzzer samples that no longer demux in our Chrome test corpus or in fate. - dale On Wed, Aug 2, 2017 at 1:43 PM, Carl Eugen Hoyos wrote: > 2017-07-31 23:40 GMT+02:00 Dale Curtis : > > [mov] Bail when invalid sample data is present. > > Could you prov

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-02 Thread Carl Eugen Hoyos
2017-07-31 23:40 GMT+02:00 Dale Curtis : > [mov] Bail when invalid sample data is present. Could you provide such a sample? Could the patch stop demuxing samples that are supported so far? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-07-31 Thread Dale Curtis
I'm not convinced my original patch catches all cases. So here's an updated one which explicitly verifies the contract. - dale On Mon, Jul 31, 2017 at 2:40 PM, Dale Curtis wrote: > [mov] Bail when invalid sample data is present. > > ctts data in ffmpeg relies on the index entries array to be 1:

[FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-07-31 Thread Dale Curtis
[mov] Bail when invalid sample data is present. ctts data in ffmpeg relies on the index entries array to be 1:1 with samples... yet sc->sample_count can be read directly from the 'stsz' box and index entries are only generated if a chunk count has been read from 'stco' box. Ensure that if sc->sam