Re: [FFmpeg-devel] [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-11 Thread Andreas Cadhalpun
On 09.08.2015 04:35, Michael Niedermayer wrote: > On Sat, Aug 08, 2015 at 09:38:39PM +0200, Andreas Cadhalpun wrote: >> Subject: [PATCH 2/6] avutil: add ff_reverse as av_reverse replacement >> >> The table is used in libavutil/eval.c. >> >> Signed-off-by: Andreas Cadhalpun > > LGTM > > thx Push

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 09:38:39PM +0200, Andreas Cadhalpun wrote: > On 08.08.2015 18:40, Martin Storsjö wrote: > > As Hendrik said, public data symbols are problematic from a portability > > point of view > > (they behave differently than public functions in DLLs and require jumping > > through

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-08 Thread Andreas Cadhalpun
On 08.08.2015 18:40, Martin Storsjö wrote: > As Hendrik said, public data symbols are problematic from a portability point > of view > (they behave differently than public functions in DLLs and require jumping > through > extra hoops, which we've chosen not to jump through - the MSVC portability

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-08 Thread Andreas Cadhalpun
On 08.08.2015 14:33, Hendrik Leppkes wrote: > On Sat, Aug 8, 2015 at 1:36 PM, Andreas Cadhalpun > wrote: >> +const uint8_t *ff_reverse = av_reverse; > > Importing data tables from another library is something we try to > avoid. Keeping a duplicate of 256 bytes is favorable. Why? > Maybe the dep