Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-24 Thread Andreas Cadhalpun
On 24.11.2016 16:38, Michael Niedermayer wrote: > On Thu, Nov 24, 2016 at 01:06:35AM +0100, Andreas Cadhalpun wrote: >> libopusdec.c |7 +++ >> 1 file changed, 7 insertions(+) >> bc2908b04551bef5476493cb7bbf0df4979f92f6 >> 0001-libopusdec-default-to-stereo-for-invalid-number-of-c.patch >

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-24 Thread Michael Niedermayer
On Thu, Nov 24, 2016 at 01:06:35AM +0100, Andreas Cadhalpun wrote: > On 23.11.2016 03:07, Michael Niedermayer wrote: > > On Mon, Nov 14, 2016 at 09:55:15PM +0100, Andreas Cadhalpun wrote: > >> libopusdec.c |6 ++ > >> 1 file changed, 6 insertions(+) > >> 0b663c14f4a6dae3e1da453239dbe429aef

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-23 Thread Andreas Cadhalpun
On 23.11.2016 03:07, Michael Niedermayer wrote: > On Mon, Nov 14, 2016 at 09:55:15PM +0100, Andreas Cadhalpun wrote: >> libopusdec.c |6 ++ >> 1 file changed, 6 insertions(+) >> 0b663c14f4a6dae3e1da453239dbe429aef7886e >> 0001-libopusdec-default-to-stereo-for-invalid-number-of-c.patch >>

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-22 Thread Michael Niedermayer
On Mon, Nov 14, 2016 at 09:55:15PM +0100, Andreas Cadhalpun wrote: > On 14.11.2016 20:54, Anton Khirnov wrote: > > Quoting Andreas Cadhalpun (2016-11-14 20:30:10) > >> On 14.11.2016 00:01, Luca Barbato wrote: > >>> On 13/11/2016 19:23, Andreas Cadhalpun wrote: > avc->channels can be 0. > >>> >

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-22 Thread Andreas Cadhalpun
On 14.11.2016 21:55, Andreas Cadhalpun wrote: > From d33ded293d15e8ceab666bea834d436f3a225bcc Mon Sep 17 00:00:00 2001 > From: Andreas Cadhalpun > Date: Mon, 14 Nov 2016 21:41:45 +0100 > Subject: [PATCH] libopusdec: default to stereo for invalid number of channels > > This fixes an out-of-bounds

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-14 Thread Carl Eugen Hoyos
2016-11-14 23:40 GMT+01:00 Andreas Cadhalpun : > On 14.11.2016 22:59, Carl Eugen Hoyos wrote: >> 2016-11-14 21:55 GMT+01:00 Andreas Cadhalpun >> : >> channels being zero is perfectly valid, it means the caller does not know the channel count and expects the decoder to read it from the >>

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-14 Thread Andreas Cadhalpun
On 14.11.2016 22:59, Carl Eugen Hoyos wrote: > 2016-11-14 21:55 GMT+01:00 Andreas Cadhalpun > : > >>> channels being zero is perfectly valid, it means the caller does not >>> know the channel count and expects the decoder to read it from the >>> bitstream. >> >> In general code this is correct, h

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-14 Thread Hendrik Leppkes
On Mon, Nov 14, 2016 at 9:55 PM, Andreas Cadhalpun wrote: > On 14.11.2016 20:54, Anton Khirnov wrote: >> Quoting Andreas Cadhalpun (2016-11-14 20:30:10) >>> On 14.11.2016 00:01, Luca Barbato wrote: On 13/11/2016 19:23, Andreas Cadhalpun wrote: > avc->channels can be 0. 0 and les

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-14 Thread Carl Eugen Hoyos
2016-11-14 21:55 GMT+01:00 Andreas Cadhalpun : >> channels being zero is perfectly valid, it means the caller does not >> know the channel count and expects the decoder to read it from the >> bitstream. > > In general code this is correct, however if e.g. the matroska demuxer > reads an audio stre

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-14 Thread Andreas Cadhalpun
On 14.11.2016 20:54, Anton Khirnov wrote: > Quoting Andreas Cadhalpun (2016-11-14 20:30:10) >> On 14.11.2016 00:01, Luca Barbato wrote: >>> On 13/11/2016 19:23, Andreas Cadhalpun wrote: avc->channels can be 0. >>> >>> 0 and less than zero shouldn't be an error? >> >> Such values should be reje

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-14 Thread Andreas Cadhalpun
On 14.11.2016 00:01, Luca Barbato wrote: > On 13/11/2016 19:23, Andreas Cadhalpun wrote: >> avc->channels can be 0. > > 0 and less than zero shouldn't be an error? Such values should be rejected, wherever they are set. However, ensuring that is a larger change I'm currently working on. Meanwhile,