Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-20 Thread Gautam Ramakrishnan
On Thu, Aug 20, 2020 at 12:55 AM Paul B Mahol wrote: > > On 8/19/20, Gautam Ramakrishnan wrote: > > On Wed, Aug 19, 2020 at 5:51 PM wrote: > >> > >> From: Gautam Ramakrishnan > >> > >> This patch allows setting a compression ratio and to > >> set multiple layers. The user has to input a compres

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-20 Thread Gautam Ramakrishnan
On Thu, Aug 20, 2020 at 8:25 PM Andreas Rheinhardt wrote: > > Gautam Ramakrishnan: > > On Thu, Aug 20, 2020 at 12:55 AM Andreas Rheinhardt > > wrote: > >> > >> Gautam Ramakrishnan: > >>> On Wed, Aug 19, 2020 at 5:51 PM wrote: > > From: Gautam Ramakrishnan > > This patch allo

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-20 Thread Andreas Rheinhardt
Gautam Ramakrishnan: > On Thu, Aug 20, 2020 at 12:55 AM Andreas Rheinhardt > wrote: >> >> Gautam Ramakrishnan: >>> On Wed, Aug 19, 2020 at 5:51 PM wrote: From: Gautam Ramakrishnan This patch allows setting a compression ratio and to set multiple layers. The user has to i

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-20 Thread Gautam Ramakrishnan
On Thu, Aug 20, 2020 at 3:36 PM Moritz Barsnick wrote: > > On Wed, Aug 19, 2020 at 17:51:02 +0530, gautamr...@gmail.com wrote: > > Minor nits: > > > +static void compute_rates(Jpeg2000EncoderContext* s) > > +{ > > +int i, j; > > +int layno, compno; > > +for (i = 0; i < s->numYtiles; i+

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-20 Thread Gautam Ramakrishnan
On Thu, Aug 20, 2020 at 12:55 AM Andreas Rheinhardt wrote: > > Gautam Ramakrishnan: > > On Wed, Aug 19, 2020 at 5:51 PM wrote: > >> > >> From: Gautam Ramakrishnan > >> > >> This patch allows setting a compression ratio and to > >> set multiple layers. The user has to input a compression > >> rat

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-20 Thread Moritz Barsnick
On Wed, Aug 19, 2020 at 17:51:02 +0530, gautamr...@gmail.com wrote: Minor nits: > +static void compute_rates(Jpeg2000EncoderContext* s) > +{ > +int i, j; > +int layno, compno; > +for (i = 0; i < s->numYtiles; i++) { > +for (j = 0; j < s->numXtiles; j++) { > +Jpeg20

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-19 Thread Andreas Rheinhardt
Gautam Ramakrishnan: > On Wed, Aug 19, 2020 at 5:51 PM wrote: >> >> From: Gautam Ramakrishnan >> >> This patch allows setting a compression ratio and to >> set multiple layers. The user has to input a compression >> ratio for each layer. >> The per layer compression ration can be set as follows:

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-19 Thread Paul B Mahol
On 8/19/20, Gautam Ramakrishnan wrote: > On Wed, Aug 19, 2020 at 5:51 PM wrote: >> >> From: Gautam Ramakrishnan >> >> This patch allows setting a compression ratio and to >> set multiple layers. The user has to input a compression >> ratio for each layer. >> The per layer compression ration can

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-19 Thread Gautam Ramakrishnan
On Wed, Aug 19, 2020 at 5:51 PM wrote: > > From: Gautam Ramakrishnan > > This patch allows setting a compression ratio and to > set multiple layers. The user has to input a compression > ratio for each layer. > The per layer compression ration can be set as follows: > -layer_rates "r1,r2,...rn" >

[FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-19 Thread gautamramk
From: Gautam Ramakrishnan This patch allows setting a compression ratio and to set multiple layers. The user has to input a compression ratio for each layer. The per layer compression ration can be set as follows: -layer_rates "r1,r2,...rn" for to create 'n' layers. --- libavcodec/j2kenc.c | 4