Re: [FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

2020-08-20 Thread Moritz Barsnick
On Thu, Aug 20, 2020 at 20:02:32 +0530, Gautam Ramakrishnan wrote: > On Thu, Aug 20, 2020 at 3:02 PM Moritz Barsnick wrote: > > ... and what it does with this change. Looks like an NOP from the patch > > file alone. > It was done to provide functionality for the next patch in the series. I then s

Re: [FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

2020-08-20 Thread Gautam Ramakrishnan
On Thu, Aug 20, 2020 at 3:02 PM Moritz Barsnick wrote: > > On Wed, Aug 19, 2020 at 17:51:01 +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > This patch makes the ff_jpeg2000_cleanup > > function take in an extra parameter which > > indicates whether it is called from the >

Re: [FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

2020-08-20 Thread Moritz Barsnick
On Wed, Aug 19, 2020 at 17:51:01 +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch makes the ff_jpeg2000_cleanup > function take in an extra parameter which > indicates whether it is called from the > encoder or decoder. I fail to see an explanation why, ... > -void f

[FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

2020-08-19 Thread gautamramk
From: Gautam Ramakrishnan This patch makes the ff_jpeg2000_cleanup function take in an extra parameter which indicates whether it is called from the encoder or decoder. --- libavcodec/j2kenc.c | 2 +- libavcodec/jpeg2000.c| 2 +- libavcodec/jpeg2000.h| 2 +- libavcodec/jpeg2000dec.c