Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-10-08 Thread Carl Eugen Hoyos
2017-10-08 1:55 GMT+02:00 Ronald S. Bultje : > Hi, > > On Sat, Oct 7, 2017 at 7:14 PM, Carl Eugen Hoyos wrote: > >> 2017-05-05 1:32 GMT+02:00 Carl Eugen Hoyos : >> > Hi! >> > >> > It may be better to disable the warning. >> >> Ping, one of the two patches should be applied, >> we currently have on

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-10-07 Thread Ronald S. Bultje
Hi, On Sat, Oct 7, 2017 at 7:14 PM, Carl Eugen Hoyos wrote: > 2017-05-05 1:32 GMT+02:00 Carl Eugen Hoyos : > > Hi! > > > > It may be better to disable the warning. > > Ping, one of the two patches should be applied, > we currently have one vote for each. > I'd go for && since it's boolean. No s

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-10-07 Thread Carl Eugen Hoyos
2017-05-05 1:32 GMT+02:00 Carl Eugen Hoyos : > Hi! > > It may be better to disable the warning. Ping, one of the two patches should be applied, we currently have one vote for each. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-05-05 Thread Tobias Rapp
On 05.05.2017 09:26, Carl Eugen Hoyos wrote: 2017-05-05 3:12 GMT+02:00 Aaron Levinson : On 5/4/2017 4:32 PM, Carl Eugen Hoyos wrote: Hi! It may be better to disable the warning. Carl Eugen -num = den ? num * intnum / den : (num * intnum ? INFINITY : NAN); +num = den ? num * i

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-05-05 Thread Michael Niedermayer
On Fri, May 05, 2017 at 09:26:05AM +0200, Carl Eugen Hoyos wrote: > 2017-05-05 3:12 GMT+02:00 Aaron Levinson : > > On 5/4/2017 4:32 PM, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> It may be better to disable the warning. > >> > >> Carl Eugen > >> > >> -num = den ? num * intnum / den : (num *

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-05-05 Thread Carl Eugen Hoyos
2017-05-05 3:12 GMT+02:00 Aaron Levinson : > On 5/4/2017 4:32 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> It may be better to disable the warning. >> >> Carl Eugen >> >> -num = den ? num * intnum / den : (num * intnum ? INFINITY : NAN); >> +num = den ? num * intnum / den : (num && intn

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-05-04 Thread Aaron Levinson
On 5/4/2017 4:32 PM, Carl Eugen Hoyos wrote: > Hi! > > It may be better to disable the warning. > > Carl Eugen > > -num = den ? num * intnum / den : (num * intnum ? INFINITY : NAN); > +num = den ? num * intnum / den : (num && intnum ? INFINITY : NAN); In order to preserve the ori

[FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-05-04 Thread Carl Eugen Hoyos
Hi! It may be better to disable the warning. Carl Eugen From ab94367f502ab00f643a78608593eb9522e5c3be Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 5 May 2017 01:30:19 +0200 Subject: [PATCH] lavu/opt: Use "&&" instead of "*" in boolean expression. Fixes the following warning: libav